[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/6] tests: pull qemu-nbd iotest helpers into co
From: |
Daniel P . Berrangé |
Subject: |
Re: [Qemu-devel] [PATCH 3/6] tests: pull qemu-nbd iotest helpers into common.nbd file |
Date: |
Mon, 19 Nov 2018 10:24:17 +0000 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Fri, Nov 16, 2018 at 03:43:16PM -0600, Eric Blake wrote:
> On 11/16/18 3:41 PM, Eric Blake wrote:
>
> > > +#!/bin/bash
> >
> > I know we're using bash,
> >
> > > +
> > > +function nbd_server_stop()
> > > +{
> >
> > > +function nbd_server_wait_for_unix_socket()
> >
> > and bash supports 'function', but it is an obsolete syntactic sugar
> > thing that I don't recommend using. (In ksh, it actually makes a
> > difference in behavior whether you use 'function' or not, and using it
> > in 'bash' makes it harder to port code over to 'ksh' - and hence in bash
> > it is obsolete because here it does NOT cause the change in behavior
> > that ksh users expect)
> >
>
> Of course, I hit send too soon, before getting to my punchline:
>
> Since we already have so many existing iotests that use 'function', it's
> better to clean that up as a separate patch.
Yeah, I actually thought 'function' was the preferred syntax and
omitting it was bad since so many iotests used it :-)
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
[Qemu-devel] [PATCH 4/6] tests: check if qemu-nbd is still alive before waiting, Daniel P . Berrangé, 2018/11/16
[Qemu-devel] [PATCH 3/6] tests: pull qemu-nbd iotest helpers into common.nbd file, Daniel P . Berrangé, 2018/11/16
Re: [Qemu-devel] [PATCH 3/6] tests: pull qemu-nbd iotest helpers into common.nbd file, Eric Blake, 2018/11/17
[Qemu-devel] [PATCH 6/6] tests: exercise NBD server in TLS mode, Daniel P . Berrangé, 2018/11/16
Re: [Qemu-devel] [PATCH 6/6] tests: exercise NBD server in TLS mode, Daniel P . Berrangé, 2018/11/19
Re: [Qemu-devel] [PATCH 6/6] tests: exercise NBD server in TLS mode, Eric Blake, 2018/11/17