Re: [Qemu-devel] [PATCH 3/6] tests: pull qemu-nbd iotest helpers into common.nbd file

[Eric Blake]

On 11/16/18 3:41 PM, Eric Blake wrote:

> > +#!/bin/bash
>
> I know we're using bash,
>
> > +
> > +function nbd_server_stop()
> > +{
>
> > +function nbd_server_wait_for_unix_socket()
>
> and bash supports 'function', but it is an obsolete syntactic sugar 
> thing that I don't recommend using.  (In ksh, it actually makes a 
> difference in behavior whether you use 'function' or not, and using it 
> in 'bash' makes it harder to port code over to 'ksh' - and hence in bash 
> it is obsolete because here it does NOT cause the change in behavior 
> that ksh users expect)

Of course, I hit send too soon, before getting to my punchline:

Since we already have so many existing iotests that use 'function', it's 
better to clean that up as a separate patch.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org