[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 11/11] target/mips: Port MIPS64 DCL[Z/O] to
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [RFC PATCH 11/11] target/mips: Port MIPS64 DCL[Z/O] to decodetree |
|
Date: |
Mon, 12 Nov 2018 10:14:56 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 |
On 11/12/18 12:36 AM, Philippe Mathieu-Daudé wrote:
> +dclz 011100 ..... ..... ..... ..... 100100 @rs_rt_rd
> ?ctx->insn_flags&ISA_MIPS64
> +dclo 011100 ..... ..... ..... ..... 100101 @rs_rt_rd
> ?ctx->insn_flags&ISA_MIPS64
This syntax I do not like. I preferred your other form,
>isa(ISA_MIPS64)
which, with a change to return false as I suggested, would
have the same effect.
As an aside, you could do
#define check_isa(ctx, which) ((ctx)->insn_flags & ISA_##which)
to reduce the decode markup to
>isa(MIPS64)
r~
- [Qemu-devel] [RFC PATCH 00/11] decodetree: Add tokens to ease checking ISA flags, Philippe Mathieu-Daudé, 2018/11/11
- [Qemu-devel] [RFC PATCH 05/11] decodetree: Force Python to print unsigned values, Philippe Mathieu-Daudé, 2018/11/11
- [Qemu-devel] [RFC PATCH 11/11] target/mips: Port MIPS64 DCL[Z/O] to decodetree, Philippe Mathieu-Daudé, 2018/11/11
- Re: [Qemu-devel] [RFC PATCH 11/11] target/mips: Port MIPS64 DCL[Z/O] to decodetree,
Richard Henderson <=
- [Qemu-devel] [RFC PATCH 07/11] scripts/decodetree: Add add_func_check(), Philippe Mathieu-Daudé, 2018/11/11
- [Qemu-devel] [RFC PATCH 03/11] target/mips: Move the !ISA_MIPS32R6 check out of decode_opc_special2_legacy, Philippe Mathieu-Daudé, 2018/11/11
- [Qemu-devel] [RFC PATCH 01/11] MAINTAINERS: Add scripts/decodetree.py to the TCG section, Philippe Mathieu-Daudé, 2018/11/11
- [Qemu-devel] [RFC PATCH 04/11] target/mips: Avoid access to CPUMIPSState from decode* functions, Philippe Mathieu-Daudé, 2018/11/11
- [Qemu-devel] [RFC PATCH 06/11] scripts/decodetree: Allow empty specifications, Philippe Mathieu-Daudé, 2018/11/11