[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 05/11] decodetree: Force Python to print uns
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [RFC PATCH 05/11] decodetree: Force Python to print unsigned values |
Date: |
Mon, 12 Nov 2018 09:57:21 +0100 |
On Mon, Nov 12, 2018 at 9:20 AM Richard Henderson
<address@hidden> wrote:
> On 11/12/18 12:36 AM, Philippe Mathieu-Daudé wrote:
> > Python internal representation is signed, so unsigned values
> > bigger than 31-bit are interpreted as signed (and printed with
> > a '-' signed).
> > Mask out to force unsigned values.
> >
> > Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> > ---
> > TODO: display error encountered:
> >
> > case 0x-1:
> > ....
> > ---
> > scripts/decodetree.py | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
>
> This must have been from a trivial input file containing only fixed field
> insns? Not saying it's wrong, but just so we know. Any chance you can build
> a
> tests/decode/ test for this? I know they're all currently related to parsing,
> but...
Yes, it is in my TODO to add this test, I have that failure in an early branch.
There is no rush with this series for now, this is not 3.2 material.
> Reviewed-by: Richard Henderson <address@hidden>
Thanks!
Phil.