[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 2/5] milkymist: Check for failure trying to load BIOS
From: |
Peter Maydell |
Subject: |
[Qemu-devel] [PULL 2/5] milkymist: Check for failure trying to load BIOS image |
Date: |
Tue, 6 Nov 2018 11:38:23 +0000 |
Check the return value from load_image_targphys(), which tells us
whether our attempt to load the BIOS image into RAM failed.
(Spotted by Coverity, CID 1190305.)
Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Acked-by: Michael Walle <address@hidden>
Message-id: address@hidden
---
hw/lm32/milkymist.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/hw/lm32/milkymist.c b/hw/lm32/milkymist.c
index 321f184595e..63c6894c955 100644
--- a/hw/lm32/milkymist.c
+++ b/hw/lm32/milkymist.c
@@ -138,7 +138,10 @@ milkymist_init(MachineState *machine)
bios_filename = qemu_find_file(QEMU_FILE_TYPE_BIOS, bios_name);
if (bios_filename) {
- load_image_targphys(bios_filename, BIOS_OFFSET, BIOS_SIZE);
+ if (load_image_targphys(bios_filename, BIOS_OFFSET, BIOS_SIZE) < 0) {
+ error_report("could not load bios '%s'", bios_filename);
+ exit(1);
+ }
}
reset_info->bootstrap_pc = BIOS_OFFSET;
--
2.19.1
- [Qemu-devel] [PULL 0/5] target-arm queue, Peter Maydell, 2018/11/06
- [Qemu-devel] [PULL 2/5] milkymist: Check for failure trying to load BIOS image,
Peter Maydell <=
- [Qemu-devel] [PULL 4/5] target/arm: Set S and PTW in 64-bit PAR format, Peter Maydell, 2018/11/06
- [Qemu-devel] [PULL 1/5] target/arm: Remove can't-happen if() from handle_vec_simd_shli(), Peter Maydell, 2018/11/06
- [Qemu-devel] [PULL 5/5] target/arm: Fix ATS1Hx instructions, Peter Maydell, 2018/11/06
- [Qemu-devel] [PULL 3/5] hw/arm/exynos4210: Zero memory allocated for Exynos4210State, Peter Maydell, 2018/11/06
- Re: [Qemu-devel] [PULL 0/5] target-arm queue, Peter Maydell, 2018/11/06