[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL V2 23/26] pcnet: fix possible buffer overflow
From: |
Jason Wang |
Subject: |
[Qemu-devel] [PULL V2 23/26] pcnet: fix possible buffer overflow |
Date: |
Fri, 19 Oct 2018 11:22:22 +0800 |
In pcnet_receive(), we try to assign size_ to size which converts from
size_t to integer. This will cause troubles when size_ is greater
INT_MAX, this will lead a negative value in size and it can then pass
the check of size < MIN_BUF_SIZE which may lead out of bound access
for both buf and buf1.
Fixing by converting the type of size to size_t.
CC: address@hidden
Reported-by: Daniel Shapira <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Jason Wang <address@hidden>
---
hw/net/pcnet.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/net/pcnet.c b/hw/net/pcnet.c
index 0c44554..d9ba04b 100644
--- a/hw/net/pcnet.c
+++ b/hw/net/pcnet.c
@@ -988,14 +988,14 @@ ssize_t pcnet_receive(NetClientState *nc, const uint8_t
*buf, size_t size_)
uint8_t buf1[60];
int remaining;
int crc_err = 0;
- int size = size_;
+ size_t size = size_;
if (CSR_DRX(s) || CSR_STOP(s) || CSR_SPND(s) || !size ||
(CSR_LOOP(s) && !s->looptest)) {
return -1;
}
#ifdef PCNET_DEBUG
- printf("pcnet_receive size=%d\n", size);
+ printf("pcnet_receive size=%zu\n", size);
#endif
/* if too small buffer, then expand it */
--
2.5.0
- [Qemu-devel] [PULL V2 11/26] qapi/migration.json: Rename COLO unknown mode to none mode., (continued)
- [Qemu-devel] [PULL V2 11/26] qapi/migration.json: Rename COLO unknown mode to none mode., Jason Wang, 2018/10/18
- [Qemu-devel] [PULL V2 12/26] qapi: Add new command to query colo status, Jason Wang, 2018/10/18
- [Qemu-devel] [PULL V2 14/26] COLO: flush host dirty ram from cache, Jason Wang, 2018/10/18
- [Qemu-devel] [PULL V2 13/26] savevm: split the process of different stages for loadvm/savevm, Jason Wang, 2018/10/18
- [Qemu-devel] [PULL V2 15/26] filter: Add handle_event method for NetFilterClass, Jason Wang, 2018/10/18
- [Qemu-devel] [PULL V2 17/26] COLO: notify net filters about checkpoint/failover event, Jason Wang, 2018/10/18
- [Qemu-devel] [PULL V2 19/26] docs: Add COLO status diagram to COLO-FT.txt, Jason Wang, 2018/10/18
- [Qemu-devel] [PULL V2 20/26] clean up callback when del virtqueue, Jason Wang, 2018/10/18
- [Qemu-devel] [PULL V2 18/26] COLO: quick failover process by kick COLO thread, Jason Wang, 2018/10/18
- [Qemu-devel] [PULL V2 22/26] rtl8139: fix possible out of bound access, Jason Wang, 2018/10/18
- [Qemu-devel] [PULL V2 23/26] pcnet: fix possible buffer overflow,
Jason Wang <=
- [Qemu-devel] [PULL V2 24/26] net: ignore packet size greater than INT_MAX, Jason Wang, 2018/10/18
- [Qemu-devel] [PULL V2 16/26] filter-rewriter: handle checkpoint and failover event, Jason Wang, 2018/10/18
- [Qemu-devel] [PULL V2 21/26] ne2000: fix possible out of bound access in ne2000_receive, Jason Wang, 2018/10/18
- [Qemu-devel] [PULL V2 25/26] e1000: indicate dropped packets in HW counters, Jason Wang, 2018/10/18
- [Qemu-devel] [PULL V2 26/26] qemu-options: Fix bad "macaddr" property in the documentation, Jason Wang, 2018/10/18
- Re: [Qemu-devel] [PULL V2 00/26] Net patches, Peter Maydell, 2018/10/19