[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL V2 21/26] ne2000: fix possible out of bound access in
From: |
Jason Wang |
Subject: |
[Qemu-devel] [PULL V2 21/26] ne2000: fix possible out of bound access in ne2000_receive |
Date: |
Fri, 19 Oct 2018 11:22:20 +0800 |
In ne2000_receive(), we try to assign size_ to size which converts
from size_t to integer. This will cause troubles when size_ is greater
INT_MAX, this will lead a negative value in size and it can then pass
the check of size < MIN_BUF_SIZE which may lead out of bound access of
for both buf and buf1.
Fixing by converting the type of size to size_t.
CC: address@hidden
Reported-by: Daniel Shapira <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Jason Wang <address@hidden>
---
hw/net/ne2000.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/net/ne2000.c b/hw/net/ne2000.c
index 07d79e3..869518e 100644
--- a/hw/net/ne2000.c
+++ b/hw/net/ne2000.c
@@ -174,7 +174,7 @@ static int ne2000_buffer_full(NE2000State *s)
ssize_t ne2000_receive(NetClientState *nc, const uint8_t *buf, size_t size_)
{
NE2000State *s = qemu_get_nic_opaque(nc);
- int size = size_;
+ size_t size = size_;
uint8_t *p;
unsigned int total_len, next, avail, len, index, mcast_idx;
uint8_t buf1[60];
@@ -182,7 +182,7 @@ ssize_t ne2000_receive(NetClientState *nc, const uint8_t
*buf, size_t size_)
{ 0xff, 0xff, 0xff, 0xff, 0xff, 0xff };
#if defined(DEBUG_NE2000)
- printf("NE2000: received len=%d\n", size);
+ printf("NE2000: received len=%zu\n", size);
#endif
if (s->cmd & E8390_STOP || ne2000_buffer_full(s))
--
2.5.0
- [Qemu-devel] [PULL V2 13/26] savevm: split the process of different stages for loadvm/savevm, (continued)
- [Qemu-devel] [PULL V2 13/26] savevm: split the process of different stages for loadvm/savevm, Jason Wang, 2018/10/18
- [Qemu-devel] [PULL V2 15/26] filter: Add handle_event method for NetFilterClass, Jason Wang, 2018/10/18
- [Qemu-devel] [PULL V2 17/26] COLO: notify net filters about checkpoint/failover event, Jason Wang, 2018/10/18
- [Qemu-devel] [PULL V2 19/26] docs: Add COLO status diagram to COLO-FT.txt, Jason Wang, 2018/10/18
- [Qemu-devel] [PULL V2 20/26] clean up callback when del virtqueue, Jason Wang, 2018/10/18
- [Qemu-devel] [PULL V2 18/26] COLO: quick failover process by kick COLO thread, Jason Wang, 2018/10/18
- [Qemu-devel] [PULL V2 22/26] rtl8139: fix possible out of bound access, Jason Wang, 2018/10/18
- [Qemu-devel] [PULL V2 23/26] pcnet: fix possible buffer overflow, Jason Wang, 2018/10/18
- [Qemu-devel] [PULL V2 24/26] net: ignore packet size greater than INT_MAX, Jason Wang, 2018/10/18
- [Qemu-devel] [PULL V2 16/26] filter-rewriter: handle checkpoint and failover event, Jason Wang, 2018/10/18
- [Qemu-devel] [PULL V2 21/26] ne2000: fix possible out of bound access in ne2000_receive,
Jason Wang <=
- [Qemu-devel] [PULL V2 25/26] e1000: indicate dropped packets in HW counters, Jason Wang, 2018/10/18
- [Qemu-devel] [PULL V2 26/26] qemu-options: Fix bad "macaddr" property in the documentation, Jason Wang, 2018/10/18
- Re: [Qemu-devel] [PULL V2 00/26] Net patches, Peter Maydell, 2018/10/19