Re: [Qemu-devel] [qemu-s390x] [PATCH v11 0/6] s390x: vfio-ap: guest dedicated crypto adapters

[Thomas Huth]

On 2018-10-11 10:12, David Hildenbrand wrote:
> On 10/10/2018 20:15, Christian Borntraeger wrote:
>>
>> On 10/10/2018 07:03 PM, Tony Krowiak wrote:
>>> This patch series is the QEMU counterpart to the KVM/kernel support for 
>>> guest dedicated crypto adapters. The KVM/kernel model is built on the 
>>> VFIO mediated device framework and provides the infrastructure for 
>>> granting exclusive guest access to crypto devices installed on the linux 
>>> host. This patch series introduces a new QEMU command line option, QEMU 
>>> object model and CPU model features to exploit the KVM/kernel model.
>>>
>>> See the detailed specifications for AP virtualization provided by this 
>>> patch set in docs/vfio-ap.txt for a more complete discussion of the 
>>> design introduced by this patch series.
>>>
>>> v10 => v11 Change log:
>>
>> Series seems to work fine.
>>
>> Christian
> 
> Had a quick glimpse over all patches, looks good and clean to me.

FWIW, with one additional g_free() in patch 5, the series now also looks
fine to me.

 Thomas