Re: [Qemu-devel] [PATCH v11 0/6] s390x: vfio-ap: guest dedicated crypto adapters

[Christian Borntraeger]

On 10/10/2018 07:03 PM, Tony Krowiak wrote:
> This patch series is the QEMU counterpart to the KVM/kernel support for 
> guest dedicated crypto adapters. The KVM/kernel model is built on the 
> VFIO mediated device framework and provides the infrastructure for 
> granting exclusive guest access to crypto devices installed on the linux 
> host. This patch series introduces a new QEMU command line option, QEMU 
> object model and CPU model features to exploit the KVM/kernel model.
> 
> See the detailed specifications for AP virtualization provided by this 
> patch set in docs/vfio-ap.txt for a more complete discussion of the 
> design introduced by this patch series.
> 
> v10 => v11 Change log:



Series seems to work fine.

Christian


> =====================
> * Replaced DO_UPCAST macros in ap.c
> * Initializing GError in vfio_ap_get_group() function (BUG)
> * Updated s390 maintainers with new files in MAINTAINERS
> * Fixed memory leak in vfio_ap_get_group() function
> 
> v9 => v10 Change log:
> ====================
> * Removed KVM_S390_VM_CPU_FEAT_AP feature from kvm.h
> * Moved check for KVM_S390_VM_CRYPTO_ENABLE_APIE from patch 2/6 to patch
>   3/6
> * Removed vfio from all function names in ap-bridge.c 
> * Removed unused macros and structure from ap-bridge.h
> * Removed unused macros from ap-device.h
> 
> v8 => v9 Change log:
> ===================
> * Removed all references to VFIO in AP bridge and bus
> * Expose AP feature only if the KVM_S390_VM_CRYPTO_ENABLE_APIE VM attribute
>   is exposed by KVM - i.e., if AP instructions are available on the linux
>   host.
> * Enable AP interpretation only if AP feature is switched on; no need to
>   disable because it is disabled by default.
> 
> v7 => v8 Change log:
> ===================
> * Enable SIE interpretation AP instructions if the CPU model feature for
>   AP instructions is turned on for the guest.
> 
> v6 => v7 Change log;
> ===================
> * Changed email address for Signed-off-by
> 
> v5 => v6 Change log:
> ===================
> * Added reset handling fo vfio-ap device
> * Added a bridge/bus to AP device object model - thanks to Halil Pasic
> 
> v4 => v5 Change log:
> ===================
> * Added MAINTAINERS entries for VFIO AP
> * Added explanation for why we are only supporting zEC12 and newer CPU 
>   models.
> * Changed CPU model feature qci=on|off to apqci=on|off
> * Misc. minor changes
> 
> v3 => v4 Change log:
> ===================
> * Made vfio-ap device unpluggable for now