[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 32/35] target/i386/kvm: do not acquire the BQL t
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH 32/35] target/i386/kvm: do not acquire the BQL to call cpu_reset_interrupt |
Date: |
Wed, 19 Sep 2018 23:19:08 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 |
On 9/17/18 6:31 PM, Emilio G. Cota wrote:
> From: Paolo Bonzini <address@hidden>
>
> It's not needed anymore.
>
> Cc: Marcelo Tosatti <address@hidden>
> Cc: Richard Henderson <address@hidden>
> Cc: Eduardo Habkost <address@hidden>
> Cc: address@hidden
> Signed-off-by: Paolo Bonzini <address@hidden>
> Signed-off-by: Emilio G. Cota <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> target/i386/kvm.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/target/i386/kvm.c b/target/i386/kvm.c
> index e40c8d5461..41c4830be8 100644
> --- a/target/i386/kvm.c
> +++ b/target/i386/kvm.c
> @@ -3007,9 +3007,7 @@ void kvm_arch_pre_run(CPUState *cpu, struct kvm_run
> *run)
> /* Inject NMI */
> if (interrupt_request & (CPU_INTERRUPT_NMI | CPU_INTERRUPT_SMI)) {
> if (interrupt_request & CPU_INTERRUPT_NMI) {
> - qemu_mutex_lock_iothread();
> cpu_reset_interrupt(cpu, CPU_INTERRUPT_NMI);
> - qemu_mutex_unlock_iothread();
> DPRINTF("injected NMI\n");
> ret = kvm_vcpu_ioctl(cpu, KVM_NMI);
> if (ret < 0) {
> @@ -3018,9 +3016,7 @@ void kvm_arch_pre_run(CPUState *cpu, struct kvm_run
> *run)
> }
> }
> if (atomic_read(&cpu->interrupt_request) & CPU_INTERRUPT_SMI) {
> - qemu_mutex_lock_iothread();
> cpu_reset_interrupt(cpu, CPU_INTERRUPT_SMI);
> - qemu_mutex_unlock_iothread();
> DPRINTF("injected SMI\n");
> ret = kvm_vcpu_ioctl(cpu, KVM_SMI);
> if (ret < 0) {
>
- [Qemu-devel] [PATCH 22/35] target/ppc: access cpu->interrupt_request with atomics, (continued)
- [Qemu-devel] [PATCH 22/35] target/ppc: access cpu->interrupt_request with atomics, Emilio G. Cota, 2018/09/17
- [Qemu-devel] [PATCH 23/35] target/s390x: access cpu->interrupt_request with atomics, Emilio G. Cota, 2018/09/17
- [Qemu-devel] [PATCH 31/35] translate-all: drop BQL assertion from cpu_interrupt, Emilio G. Cota, 2018/09/17
- [Qemu-devel] [PATCH 32/35] target/i386/kvm: do not acquire the BQL to call cpu_reset_interrupt, Emilio G. Cota, 2018/09/17
- [Qemu-devel] [PATCH 33/35] target/ppc: do not acquire the BQL to call cpu_interrupt, Emilio G. Cota, 2018/09/17
- Re: [Qemu-devel] [PATCH 00/35] exec: drop BQL from interrupt handling, David Hildenbrand, 2018/09/18
- Re: [Qemu-devel] [PATCH 00/35] exec: drop BQL from interrupt handling, Mark Cave-Ayland, 2018/09/20