Re: [Qemu-devel] [PATCH 2/7] hw/nvram/nrf51_nvm: Add nRF51 non-volatile memories

[Steffen Görtz]

Hi Peter,

>> +
>> +static Property nrf51_nvm_properties[] = {
>> +    DEFINE_PROP_UINT16("page_size", Nrf51NVMState, page_size, 0x400),
> 
> Do the different NRF51 variants really have different NAND page sizes ?
> 

it seems that is not the case at least for the NRF51 Series. I removed the 
property in favor for a nrf51.h-wide constant. I think this is NOR flash btw, 
because it is single-byte writable, which is usually a sign that it is NOR 
flash. But i could be wrong and the datasheet does not state anything.
Thank you for your remarks!

Steffen