qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 5/7] tests/microbit-test: Add Tests for nRF51 GP


From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [PATCH 5/7] tests/microbit-test: Add Tests for nRF51 GPIO
Date: Thu, 9 Aug 2018 17:14:49 +0100

On Mon, Aug 6, 2018 at 11:01 AM, Steffen Görtz
<address@hidden> wrote:
> +    /* Check Input propagates */
> +    g_assert_false(true);

Each patch must compile and run successfully.  This test case will
fail here.  Please don't do this - even if a later patch will fill in
the missing part.

The reason for this requirement is that git-bisect(1) must work on any
commit.  If the some commits don't compile or pass tests then it makes
git-bisect(1) much harder or impossible to use.

Stefan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]