|
From: | Alberto Garcia |
Subject: | Re: [Qemu-devel] [PATCH] throttle-groups: fix hang when group member leaves |
Date: | Tue, 31 Jul 2018 15:47:20 +0200 |
User-agent: | Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Wed 04 Jul 2018 04:54:10 PM CEST, Stefan Hajnoczi wrote: > Throttle groups consist of members sharing one throttling state > (including bps/iops limits). Round-robin scheduling is used to ensure > fairness. If a group member already has a timer pending then other > groups members do not schedule their own timers. The next group > member will have its turn when the existing timer expires. > > A hang may occur when a group member leaves while it had a timer > scheduled. I haven't been able to reproduce this. When a member is removed from the group the pending request queue must already be empty, so does this mean that there's still a timer when the queue is already empty? Berto
[Prev in Thread] | Current Thread | [Next in Thread] |