Re: [Qemu-devel] [PATCH v2 08/23] test-qobject-input-visitor: Avoid format string ambiguity

[Eric Blake]

On 07/27/2018 10:13 AM, Markus Armbruster wrote:
> When visitor_input_test_init_internal()'s argument @ap is null, then
> @json_string is interpreted literally, else it's gets %-escapes
> interpolated.  This is awkward.
>
> One caller always passes null @ap, and the others never do.  Lift the
> building of the QObject into the callers, where it can be done without
> such ambiguity.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>   tests/test-qobject-input-visitor.c | 19 ++++++++++---------
>   1 file changed, 10 insertions(+), 9 deletions(-)

Reviewed-by: Eric Blake <address@hidden>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org