[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 22/23] libqtest: Replace qtest_startf() by qt
|
From: |
Thomas Huth |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 22/23] libqtest: Replace qtest_startf() by qtest_initf() |
|
Date: |
Fri, 27 Jul 2018 19:18:08 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 07/27/2018 05:13 PM, Markus Armbruster wrote:
> qtest_init() creates a new QTestState, and leaves @global_qtest alone.
> qtest_start() additionally assigns it to @global_qtest, but
> qtest_startf() additionall sets assigns NULL to @global_qtest. This
> makes no sense. Replace it by qtest_initf() that works like
> qtest_init(), i.e. leaves @global_qtest alone.
FWIW, the original idea was to get rid of global_qtest, and then to
remove qtest_init instead:
https://lists.gnu.org/archive/html/qemu-devel/2017-09/msg02723.html
Not sure whether Eric is still working on these patches, though.
Thomas
- Re: [Qemu-devel] [PATCH v2 08/23] test-qobject-input-visitor: Avoid format string ambiguity, (continued)
- [Qemu-devel] [PATCH v2 03/23] libqtest: Clean up how we read device_del messages, Markus Armbruster, 2018/07/27
- [Qemu-devel] [PATCH v2 06/23] qobject: New qobject_from_vjsonf_nofail(), qdict_from_vjsonf_nofail(), Markus Armbruster, 2018/07/27
- [Qemu-devel] [PATCH v2 09/23] qobject: qobject_from_jsonv() is dangerous, hide it away, Markus Armbruster, 2018/07/27
- [Qemu-devel] [PATCH v2 22/23] libqtest: Replace qtest_startf() by qtest_initf(), Markus Armbruster, 2018/07/27
- [Qemu-devel] [PATCH v2 19/23] migration-test: Clean up string interpolation into QMP, part 3, Markus Armbruster, 2018/07/27
- [Qemu-devel] [PATCH v2 21/23] libqtest: Remove qtest_qmp_discard_response() & friends, Markus Armbruster, 2018/07/27
- Re: [Qemu-devel] [PATCH v2 21/23] libqtest: Remove qtest_qmp_discard_response() & friends, Eric Blake, 2018/07/27