[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 12/17] docker: report hint when docker.py check fails
From: |
Alex Bennée |
Subject: |
[Qemu-devel] [PULL 12/17] docker: report hint when docker.py check fails |
Date: |
Tue, 24 Jul 2018 11:51:04 +0100 |
When a check fails we currently just report why we failed. This is not
totally helpful to people who want to boot-strap a new image. Report a
hint as to why it failed.
Signed-off-by: Alex Bennée <address@hidden>
Suggested-by: Fam Zheng <address@hidden>
diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include
index 05afeb64a7..1aaa795743 100644
--- a/tests/docker/Makefile.include
+++ b/tests/docker/Makefile.include
@@ -73,7 +73,8 @@ docker-binfmt-image-debian-%:
$(DOCKER_FILES_DIR)/debian-bootstrap.docker
$(if $(EXECUTABLE),--include-executable=$(EXECUTABLE)),
\
"BUILD","binfmt debian-$* (debootstrapped)"),
\
$(call quiet-command,
\
- $(DOCKER_SCRIPT) check --quiet qemu:debian-$* $<,
\
+ $(DOCKER_SCRIPT) check --quiet qemu:debian-$* $< ||
\
+ { echo "You will need to build $(EXECUTABLE)"; exit
1;},\
"CHECK", "debian-$* exists"))
endif
--
2.17.1
- [Qemu-devel] [PULL for 3.0 00/17] docker fixes and tcg test tweak, Alex Bennée, 2018/07/24
- [Qemu-devel] [PULL 01/17] tests/.gitignore: don't ignore docker tests, Alex Bennée, 2018/07/24
- [Qemu-devel] [PULL 03/17] docker: par down QEMU_CONFIGURE_OPTS in debian-tricore-cross, Alex Bennée, 2018/07/24
- [Qemu-devel] [PULL 04/17] docker: fail more gracefully on docker.py check, Alex Bennée, 2018/07/24
- [Qemu-devel] [PULL 05/17] docker: split configure_qemu from build_qemu, Alex Bennée, 2018/07/24
- [Qemu-devel] [PULL 06/17] docker: move make check into check_qemu helper, Alex Bennée, 2018/07/24
- [Qemu-devel] [PULL 02/17] docker: base debian-tricore on qemu:debian9, Alex Bennée, 2018/07/24
- [Qemu-devel] [PULL 07/17] docker: gracefully skip check_qemu, Alex Bennée, 2018/07/24
- [Qemu-devel] [PULL 11/17] docker: drop QEMU_TARGET check, fallback in EXECUTABLE not set, Alex Bennée, 2018/07/24
- [Qemu-devel] [PULL 08/17] docker: Makefile.include don't include partial images, Alex Bennée, 2018/07/24
- [Qemu-devel] [PULL 12/17] docker: report hint when docker.py check fails,
Alex Bennée <=
- [Qemu-devel] [PULL 10/17] docker: add expansion for docker-test-FOO to Makefile.include, Alex Bennée, 2018/07/24
- [Qemu-devel] [PULL 09/17] docker: add test-unit runner, Alex Bennée, 2018/07/24
- [Qemu-devel] [PULL 15/17] docker: ignore distro versioning of debootstrap, Alex Bennée, 2018/07/24
- [Qemu-devel] [PULL 13/17] docker: Update debootstrap script after Debian migration from Alioth to Salsa, Alex Bennée, 2018/07/24
- [Qemu-devel] [PULL 14/17] docker: add commentary to debian-bootstrap.docker, Alex Bennée, 2018/07/24
- [Qemu-devel] [PULL 17/17] tests/tcg: remove runcom test, Alex Bennée, 2018/07/24
- [Qemu-devel] [PULL 16/17] docker: perform basic binfmt_misc validation in docker.py, Alex Bennée, 2018/07/24
- Re: [Qemu-devel] [PULL for 3.0 00/17] docker fixes and tcg test tweak, Peter Maydell, 2018/07/24