[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 04/17] docker: fail more gracefully on docker.py chec
From: |
Alex Bennée |
Subject: |
[Qemu-devel] [PULL 04/17] docker: fail more gracefully on docker.py check |
Date: |
Tue, 24 Jul 2018 11:50:56 +0100 |
As this is called directly from the Makefile while determining
dependencies and it is possible the user was configured in one window
but not have credentials in the other. Let's catch the Exceptions and
deal with it quietly.
Signed-off-by: Alex Bennée <address@hidden>
Reported-by: Peter Maydell <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
diff --git a/tests/docker/docker.py b/tests/docker/docker.py
index 69e7130db7..2f81c6b13b 100755
--- a/tests/docker/docker.py
+++ b/tests/docker/docker.py
@@ -479,7 +479,12 @@ class CheckCommand(SubCommand):
def run(self, args, argv):
tag = args.tag
- dkr = Docker()
+ try:
+ dkr = Docker()
+ except:
+ print("Docker not set up")
+ return 1
+
info = dkr.inspect_tag(tag)
if info is None:
print("Image does not exist")
--
2.17.1
- [Qemu-devel] [PULL for 3.0 00/17] docker fixes and tcg test tweak, Alex Bennée, 2018/07/24
- [Qemu-devel] [PULL 01/17] tests/.gitignore: don't ignore docker tests, Alex Bennée, 2018/07/24
- [Qemu-devel] [PULL 03/17] docker: par down QEMU_CONFIGURE_OPTS in debian-tricore-cross, Alex Bennée, 2018/07/24
- [Qemu-devel] [PULL 04/17] docker: fail more gracefully on docker.py check,
Alex Bennée <=
- [Qemu-devel] [PULL 05/17] docker: split configure_qemu from build_qemu, Alex Bennée, 2018/07/24
- [Qemu-devel] [PULL 06/17] docker: move make check into check_qemu helper, Alex Bennée, 2018/07/24
- [Qemu-devel] [PULL 02/17] docker: base debian-tricore on qemu:debian9, Alex Bennée, 2018/07/24
- [Qemu-devel] [PULL 07/17] docker: gracefully skip check_qemu, Alex Bennée, 2018/07/24
- [Qemu-devel] [PULL 11/17] docker: drop QEMU_TARGET check, fallback in EXECUTABLE not set, Alex Bennée, 2018/07/24
- [Qemu-devel] [PULL 08/17] docker: Makefile.include don't include partial images, Alex Bennée, 2018/07/24
- [Qemu-devel] [PULL 12/17] docker: report hint when docker.py check fails, Alex Bennée, 2018/07/24
- [Qemu-devel] [PULL 10/17] docker: add expansion for docker-test-FOO to Makefile.include, Alex Bennée, 2018/07/24
- [Qemu-devel] [PULL 09/17] docker: add test-unit runner, Alex Bennée, 2018/07/24
- [Qemu-devel] [PULL 15/17] docker: ignore distro versioning of debootstrap, Alex Bennée, 2018/07/24