Re: [Qemu-devel] [PATCH v3 4/8] target/mips: Avoid case statements formulated by ranges

[Richard Henderson]

On 07/04/2018 12:30 PM, Aleksandar Markovic wrote:
>      case 18:
>          switch (sel) {
> -        case 0 ... 7:
> +        case 0:
> +        case 1:
> +        case 2:
> +        case 3:
> +        case 4:
> +        case 5:
> +        case 6:
> +        case 7:

I don't see the point in this.  It is clear what 0 ... 7 means.

> -    case OPC_MULT ... OPC_DIVU:
> +    case OPC_MULT:
> +    case OPC_MULTU:
> +    case OPC_DIV:
> +    case OPC_DIVU:

These on the other hand are a good cleanup, because there's no obvious
relationship between the beginning and end of the range.


r~