[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v16 09/14] migration: Create multifd_bytes ram_c
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH v16 09/14] migration: Create multifd_bytes ram_counter |
Date: |
Wed, 27 Jun 2018 11:01:36 +0100 |
User-agent: |
Mutt/1.10.0 (2018-05-17) |
* Juan Quintela (address@hidden) wrote:
> This will include how many bytes they are sent through multifd.
>
> Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
> ---
> hmp.c | 2 ++
> migration/migration.c | 1 +
> qapi/migration.json | 5 ++++-
> 3 files changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/hmp.c b/hmp.c
> index f601099f90..0da0b0ac33 100644
> --- a/hmp.c
> +++ b/hmp.c
> @@ -234,6 +234,8 @@ void hmp_info_migrate(Monitor *mon, const QDict *qdict)
> info->ram->dirty_sync_count);
> monitor_printf(mon, "page size: %" PRIu64 " kbytes\n",
> info->ram->page_size >> 10);
> + monitor_printf(mon, "multifd bytes: %" PRIu64 " kbytes\n",
> + info->ram->multifd_bytes >> 10);
>
> if (info->ram->dirty_pages_rate) {
> monitor_printf(mon, "dirty pages rate: %" PRIu64 " pages\n",
> diff --git a/migration/migration.c b/migration/migration.c
> index 264f3ce84e..2680ba2d47 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -708,6 +708,7 @@ static void populate_ram_info(MigrationInfo *info,
> MigrationState *s)
> info->ram->dirty_sync_count = ram_counters.dirty_sync_count;
> info->ram->postcopy_requests = ram_counters.postcopy_requests;
> info->ram->page_size = qemu_target_page_size();
> + info->ram->multifd_bytes = ram_counters.multifd_bytes;
>
> if (migrate_use_xbzrle()) {
> info->has_xbzrle_cache = true;
> diff --git a/qapi/migration.json b/qapi/migration.json
> index 1b4c1db670..186e8a7303 100644
> --- a/qapi/migration.json
> +++ b/qapi/migration.json
> @@ -39,6 +39,8 @@
> # @page-size: The number of bytes per page for the various page-based
> # statistics (since 2.10)
> #
> +# @multifd-bytes: The number of bytes sent through multifd (since 3.0)
> +#
> # Since: 0.14.0
> ##
> { 'struct': 'MigrationStats',
> @@ -46,7 +48,8 @@
> 'duplicate': 'int', 'skipped': 'int', 'normal': 'int',
> 'normal-bytes': 'int', 'dirty-pages-rate' : 'int',
> 'mbps' : 'number', 'dirty-sync-count' : 'int',
> - 'postcopy-requests' : 'int', 'page-size' : 'int' } }
> + 'postcopy-requests' : 'int', 'page-size' : 'int',
> + 'multifd-bytes' : 'uint64' } }
>
> ##
> # @XBZRLECacheStats:
> --
> 2.17.1
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- [Qemu-devel] [PATCH v16 01/14] migration: Create multipage support, Juan Quintela, 2018/06/26
- [Qemu-devel] [PATCH v16 04/14] migration: Abstract the number of bytes sent, Juan Quintela, 2018/06/26
- [Qemu-devel] [PATCH v16 03/14] migration: Calculate mbps only during transfer time, Juan Quintela, 2018/06/26
- [Qemu-devel] [PATCH v16 02/14] migration: Create multifd packet, Juan Quintela, 2018/06/26
- [Qemu-devel] [PATCH v16 05/14] migration: Add multifd traces for start/end thread, Juan Quintela, 2018/06/26
- [Qemu-devel] [PATCH v16 06/14] migration: Multifd channels always wait on the sem, Juan Quintela, 2018/06/26
- [Qemu-devel] [PATCH v16 07/14] migration: Add block where to send/receive packets, Juan Quintela, 2018/06/26
- [Qemu-devel] [PATCH v16 09/14] migration: Create multifd_bytes ram_counter, Juan Quintela, 2018/06/26
- Re: [Qemu-devel] [PATCH v16 09/14] migration: Create multifd_bytes ram_counter,
Dr. David Alan Gilbert <=
- [Qemu-devel] [PATCH v16 08/14] migration: Synchronize multifd threads with main thread, Juan Quintela, 2018/06/26
- [Qemu-devel] [PATCH v16 11/14] migration: Start sending messages, Juan Quintela, 2018/06/26
- [Qemu-devel] [PATCH v16 12/14] migration: Wait for blocking IO, Juan Quintela, 2018/06/26
- [Qemu-devel] [PATCH v16 13/14] migration: Remove not needed semaphore and quit, Juan Quintela, 2018/06/26
- [Qemu-devel] [PATCH v16 10/14] migration: Create ram_save_multifd_page, Juan Quintela, 2018/06/26
- [Qemu-devel] [PATCH v16 14/14] migration: Stop sending whole pages through main channel, Juan Quintela, 2018/06/26