[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2] monitor: report entirety of hmp command on e

From: Collin Walling
Subject: Re: [Qemu-devel] [PATCH v2] monitor: report entirety of hmp command on error
Date: Mon, 7 May 2018 13:10:40 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0

On 05/07/2018 12:44 PM, Eric Blake wrote:
> On 05/07/2018 09:30 AM, Collin Walling wrote:
>> When a user incorrectly provides an hmp command, an error response will be
>> printed that prompts the user to try "help <command name>". However, when
>> the command contains multiple parts e.g. "info uuid xyz", only the last
>> whitespace delimited string will be reported (in this example "info" will
>> be dropped and the message will read "Try "help uuid" for more information",
>> which is incorrect).
>> Let's correct this by capturing the entirety of the command from the command
>> line -- excluding any extraneous characters.
> It's better to post a v2 patch as a new top-level thread instead of in-reply 
> to an earlier version, as some of our automated tooling is more likely to see 
> it.
>> Reported-by: Mikhail Fokin <address@hidden>
>> Signed-off-by: Collin Walling <address@hidden>
>> ---
>>   monitor.c | 8 ++++++--
>>   1 file changed, 6 insertions(+), 2 deletions(-)
> Reviewed-by: Eric Blake <address@hidden>

Noted. And thank you for the r-b.

- Collin Walling

reply via email to

[Prev in Thread] Current Thread [Next in Thread]