Re: [Qemu-devel] [PATCH] monitor: report entirety of hmp command on error

[Eric Blake]

On 05/04/2018 09:49 AM, Collin Walling wrote:
> When a user incorrectly provides an hmp command, an error response will be
> printed that prompts the user to try "help <command name>". However, when
> the command contains multiple parts e.g. "info skeys", only the last
> whitespace delimited string will be reported (in this example "info" will
> be dropped and the message will read "Try "help skeys" for more information",
> which is incorrect).
>
> Let's correct this by capturing the full name of the command as we recurse
> through the function monitor_parse_command.
>
> Reported-by: Mikhail Fokin <address@hidden>
> Signed-off-by: Collin Walling <address@hidden>

Side note:

git shortlog --author=Collin

lists two different spellings for your name based on your previous 
contributions.  You may want to propose a patch to .mailmap to settle on 
the variant that you prefer, so that people grabbing statistics from git 
don't get as confused.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org