[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 60/67] hw/s390x: add include directory headers
From: |
Cornelia Huck |
Subject: |
Re: [Qemu-devel] [PATCH 60/67] hw/s390x: add include directory headers |
Date: |
Fri, 4 May 2018 09:10:07 +0200 |
On Thu, 3 May 2018 22:51:40 +0300
"Michael S. Tsirkin" <address@hidden> wrote:
> This way they are easier to find using standard rules.
>
> Signed-off-by: Michael S. Tsirkin <address@hidden>
> ---
> include/hw/s390x/ccw-device.h | 1 +
> include/hw/s390x/ipl.h | 1 +
> include/hw/s390x/s390-pci-bus.h | 1 +
> include/hw/s390x/s390-pci-inst.h | 1 +
> include/hw/s390x/s390-virtio-hcall.h | 1 +
> include/hw/s390x/virtio-ccw.h | 1 +
> 6 files changed, 6 insertions(+)
> create mode 100644 include/hw/s390x/ccw-device.h
> create mode 100644 include/hw/s390x/ipl.h
> create mode 100644 include/hw/s390x/s390-pci-bus.h
> create mode 100644 include/hw/s390x/s390-pci-inst.h
> create mode 100644 include/hw/s390x/s390-virtio-hcall.h
> create mode 100644 include/hw/s390x/virtio-ccw.h
>
> diff --git a/include/hw/s390x/ccw-device.h b/include/hw/s390x/ccw-device.h
> new file mode 100644
> index 0000000..ab761b3
> --- /dev/null
> +++ b/include/hw/s390x/ccw-device.h
> @@ -0,0 +1 @@
> +#include_next "../hw/s390x/ccw-device.h"
Eww. I find this very ugly.
[Goes to find cover letter to figure out what this is all about.
*Please*, cc: people on the cover letter so they can see immediately
what this is trying to do!]
After reading the cover letter, I still don't like this. If you want to
move headers under include/ (which I don't have a problem with), please
move them and do not introduce these weird constructs.
[Also, that might need a MAINTAINERS update :)]
- [Qemu-devel] [PATCH 51/67] hyperv: add include directory header, (continued)
- [Qemu-devel] [PATCH 51/67] hyperv: add include directory header, Michael S. Tsirkin, 2018/05/03
- [Qemu-devel] [PATCH 55/67] amd_iommu: add include directory header, Michael S. Tsirkin, 2018/05/03
- [Qemu-devel] [PATCH 54/67] amd_iommu: add include directory header, Michael S. Tsirkin, 2018/05/03
- [Qemu-devel] [PATCH 58/67] target/riscv: add include directory header, Michael S. Tsirkin, 2018/05/03
- [Qemu-devel] [PATCH 56/67] tcg: use include "tcg-gvec-desc.h.h" consistently, Michael S. Tsirkin, 2018/05/03
- [Qemu-devel] [PATCH 59/67] hw/ppc: add target headers explicitly, Michael S. Tsirkin, 2018/05/03
- [Qemu-devel] [PATCH 57/67] kvm: use include "kvm_i386.h" consistently, Michael S. Tsirkin, 2018/05/03
- [Qemu-devel] [PATCH 60/67] hw/s390x: add include directory headers, Michael S. Tsirkin, 2018/05/03
[Qemu-devel] [PATCH 61/67] hw/net: add include directory header, Michael S. Tsirkin, 2018/05/03
[Qemu-devel] [PATCH 62/67] kvm: use include "kvm_ppc.h" consistently, Michael S. Tsirkin, 2018/05/03
[Qemu-devel] [PATCH 63/67] hw/s390x: use target headers explicitly, Michael S. Tsirkin, 2018/05/03