Re: [Qemu-devel] [PATCH v1 03/29] target-microblaze: compute_ldst_addr: Use bool instead of int

[Alistair Francis]

On Thu, May 3, 2018 at 2:19 AM Edgar E. Iglesias <address@hidden>
wrote:

> From: "Edgar E. Iglesias" <address@hidden>

> Use bool instead of int to represent flags.
> No functional change.

> Signed-off-by: Edgar E. Iglesias <address@hidden>

Reviewed-by: Alistair Francis <address@hidden>

Alistair

> ---
>   target/microblaze/translate.c | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)

> diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c
> index 6fe679ca6d..9232b42a8a 100644
> --- a/target/microblaze/translate.c
> +++ b/target/microblaze/translate.c
> @@ -845,13 +845,13 @@ static void dec_imm(DisasContext *dc)

>   static inline TCGv *compute_ldst_addr(DisasContext *dc, TCGv *t)
>   {
> -    unsigned int extimm = dc->tb_flags & IMM_FLAG;
> -    /* Should be set to one if r1 is used by loadstores.  */
> -    int stackprot = 0;
> +    bool extimm = dc->tb_flags & IMM_FLAG;
> +    /* Should be set to true if r1 is used by loadstores.  */
> +    bool stackprot = false;

>       /* All load/stores use ra.  */
>       if (dc->ra == 1 && dc->cpu->cfg.stackprot) {
> -        stackprot = 1;
> +        stackprot = true;
>       }

>       /* Treat the common cases first.  */
> @@ -864,7 +864,7 @@ static inline TCGv *compute_ldst_addr(DisasContext
*dc, TCGv *t)
>           }

>           if (dc->rb == 1 && dc->cpu->cfg.stackprot) {
> -            stackprot = 1;
> +            stackprot = true;
>           }

>           *t = tcg_temp_new();
> --
> 2.14.1