[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 08/17] replay: introduce info hmp/qmp comman
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [RFC PATCH 08/17] replay: introduce info hmp/qmp command |
Date: |
Wed, 25 Apr 2018 14:06:28 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 04/25/2018 07:46 AM, Pavel Dovgalyuk wrote:
> This patch introduces 'info replay' monitor command and
> corresponding qmp request.
> These commands request the current record/replay mode, replay log file name,
> and the execution step (number or recorded/replayed instructions).
>
> Signed-off-by: Pavel Dovgalyuk <address@hidden>
> ---
Focusing on the QMP portion:
> +++ b/qapi/misc.json
> @@ -3449,3 +3449,39 @@
> ##
> { 'command': 'x-oob-test', 'data' : { 'lock': 'bool' },
> 'allow-oob': true }
> +
> +##
> +# @ReplayInfo:
> +#
> +# Status of the record/replay mode.
> +#
> +# @mode: current mode.
> +#
> +# @filename: name of the record/replay log file.
> +#
> +# @step: current step number.
> +#
> +# Since: 2.13
> +#
> +##
> +{ 'struct': 'ReplayInfo',
> + 'data': { 'mode': 'ReplayMode', '*filename': 'str', 'step': 'int' } }
> +
> +
> +##
> +# @info_replay:
Please call this 'query-replay', for consistency with other QMP commands
(your version looks too much like an HMP command).
> +#
> +# Retrieves the status of the execution record/replay.
> +#
> +# Returns: structure with the properties of the record/replay.
> +#
> +# Since: 2.13
> +#
> +# Example:
> +#
> +# -> { "execute": "info_replay" }
> +# <- { "return": { "mode": "play", "filename": "log.rr", "step": 220414 } }
> +#
> +##
> +{ 'command': 'info_replay',
> + 'returns': 'ReplayInfo' }
Please put these additions to misc.json be grouped closer to the
existing ReplayMode definition
> diff --git a/replay/Makefile.objs b/replay/Makefile.objs
> index cee6539..6694e3e 100644
> --- a/replay/Makefile.objs
> +++ b/replay/Makefile.objs
> @@ -6,4 +6,5 @@ common-obj-y += replay-input.o
> common-obj-y += replay-char.o
> common-obj-y += replay-snapshot.o
> common-obj-y += replay-net.o
> -common-obj-y += replay-audio.o
> \ No newline at end of file
Eww, that's an existing trivial bug that we should fix (POSIX says that
Makefiles should be text files, and that text files should end in a
newline). Just because GNU make handles a missing trailing newline on
makefile include fragments doesn't mean we should rely on it.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [RFC PATCH 01/17] block: implement bdrv_snapshot_goto for blkreplay, (continued)
- [Qemu-devel] [RFC PATCH 01/17] block: implement bdrv_snapshot_goto for blkreplay, Pavel Dovgalyuk, 2018/04/25
- [Qemu-devel] [RFC PATCH 02/17] replay: disable default snapshot for record/replay, Pavel Dovgalyuk, 2018/04/25
- [Qemu-devel] [RFC PATCH 03/17] replay: update docs for record/replay with block devices, Pavel Dovgalyuk, 2018/04/25
- [Qemu-devel] [RFC PATCH 04/17] replay: don't drain/flush bdrv queue while RR is working, Pavel Dovgalyuk, 2018/04/25
- [Qemu-devel] [RFC PATCH 06/17] migration: introduce icount field for snapshots, Pavel Dovgalyuk, 2018/04/25
- [Qemu-devel] [RFC PATCH 05/17] replay: finish record/replay before closing the disks, Pavel Dovgalyuk, 2018/04/25
- [Qemu-devel] [RFC PATCH 07/17] qcow2: introduce icount field for snapshots, Pavel Dovgalyuk, 2018/04/25
- [Qemu-devel] [RFC PATCH 08/17] replay: introduce info hmp/qmp command, Pavel Dovgalyuk, 2018/04/25
- Re: [Qemu-devel] [RFC PATCH 08/17] replay: introduce info hmp/qmp command,
Eric Blake <=
- [Qemu-devel] [RFC PATCH 09/17] replay: introduce breakpoint at the specified step, Pavel Dovgalyuk, 2018/04/25
- [Qemu-devel] [RFC PATCH 10/17] replay: implement replay_seek command to proceed to the desired step, Pavel Dovgalyuk, 2018/04/25
- [Qemu-devel] [RFC PATCH 11/17] replay: flush events when exitting, Pavel Dovgalyuk, 2018/04/25
- [Qemu-devel] [RFC PATCH 12/17] timer: remove replay clock probe in deadline calculation, Pavel Dovgalyuk, 2018/04/25
- [Qemu-devel] [RFC PATCH 13/17] replay: refine replay-time module, Pavel Dovgalyuk, 2018/04/25
- [Qemu-devel] [RFC PATCH 15/17] replay: flush rr queue before loading the vmstate, Pavel Dovgalyuk, 2018/04/25
- [Qemu-devel] [RFC PATCH 14/17] translator: fix breakpoint processing, Pavel Dovgalyuk, 2018/04/25
- [Qemu-devel] [RFC PATCH 17/17] gdbstub: add reverse continue support in replay mode, Pavel Dovgalyuk, 2018/04/25