[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [RFC PATCH 13/17] replay: refine replay-time module
From: |
Pavel Dovgalyuk |
Subject: |
[Qemu-devel] [RFC PATCH 13/17] replay: refine replay-time module |
Date: |
Wed, 25 Apr 2018 15:46:49 +0300 |
User-agent: |
StGit/0.17.1-dirty |
This patch removes refactoring artifacts from the replay/replay-time.c
Signed-off-by: Pavel Dovgalyuk <address@hidden>
---
replay/replay-time.c | 27 ++++++++++-----------------
1 file changed, 10 insertions(+), 17 deletions(-)
diff --git a/replay/replay-time.c b/replay/replay-time.c
index 6a7565e..40030b8 100644
--- a/replay/replay-time.c
+++ b/replay/replay-time.c
@@ -17,14 +17,12 @@
int64_t replay_save_clock(ReplayClockKind kind, int64_t clock)
{
+ g_assert(replay_file);
+ g_assert(replay_mutex_locked());
- if (replay_file) {
- g_assert(replay_mutex_locked());
-
- replay_save_instructions();
- replay_put_event(EVENT_CLOCK + kind);
- replay_put_qword(clock);
- }
+ replay_save_instructions();
+ replay_put_event(EVENT_CLOCK + kind);
+ replay_put_qword(clock);
return clock;
}
@@ -46,20 +44,15 @@ void replay_read_next_clock(ReplayClockKind kind)
/*! Reads next clock event from the input. */
int64_t replay_read_clock(ReplayClockKind kind)
{
+ int64_t ret;
g_assert(replay_file && replay_mutex_locked());
replay_account_executed_instructions();
- if (replay_file) {
- int64_t ret;
- if (replay_next_event_is(EVENT_CLOCK + kind)) {
- replay_read_next_clock(kind);
- }
- ret = replay_state.cached_clock[kind];
-
- return ret;
+ if (replay_next_event_is(EVENT_CLOCK + kind)) {
+ replay_read_next_clock(kind);
}
+ ret = replay_state.cached_clock[kind];
- error_report("REPLAY INTERNAL ERROR %d", __LINE__);
- exit(1);
+ return ret;
}
- [Qemu-devel] [RFC PATCH 07/17] qcow2: introduce icount field for snapshots, (continued)
- [Qemu-devel] [RFC PATCH 07/17] qcow2: introduce icount field for snapshots, Pavel Dovgalyuk, 2018/04/25
- [Qemu-devel] [RFC PATCH 08/17] replay: introduce info hmp/qmp command, Pavel Dovgalyuk, 2018/04/25
- [Qemu-devel] [RFC PATCH 09/17] replay: introduce breakpoint at the specified step, Pavel Dovgalyuk, 2018/04/25
- [Qemu-devel] [RFC PATCH 10/17] replay: implement replay_seek command to proceed to the desired step, Pavel Dovgalyuk, 2018/04/25
- [Qemu-devel] [RFC PATCH 11/17] replay: flush events when exitting, Pavel Dovgalyuk, 2018/04/25
- [Qemu-devel] [RFC PATCH 12/17] timer: remove replay clock probe in deadline calculation, Pavel Dovgalyuk, 2018/04/25
- [Qemu-devel] [RFC PATCH 13/17] replay: refine replay-time module,
Pavel Dovgalyuk <=
- [Qemu-devel] [RFC PATCH 15/17] replay: flush rr queue before loading the vmstate, Pavel Dovgalyuk, 2018/04/25
- [Qemu-devel] [RFC PATCH 14/17] translator: fix breakpoint processing, Pavel Dovgalyuk, 2018/04/25
- [Qemu-devel] [RFC PATCH 17/17] gdbstub: add reverse continue support in replay mode, Pavel Dovgalyuk, 2018/04/25
- [Qemu-devel] [RFC PATCH 16/17] gdbstub: add reverse step support in replay mode, Pavel Dovgalyuk, 2018/04/25
- Re: [Qemu-devel] [RFC PATCH 00/17] reverse debugging, Pavel Dovgalyuk, 2018/04/25
- Re: [Qemu-devel] [RFC PATCH 00/17] reverse debugging, Ciro Santilli, 2018/04/26
Message not available
Message not available