[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 03/16] xen: link against xentoolcore
From: |
Ian Jackson |
Subject: |
Re: [Qemu-devel] [PATCH 03/16] xen: link against xentoolcore |
Date: |
Tue, 24 Apr 2018 15:28:50 +0100 |
Anthony PERARD writes ("Re: [PATCH 03/16] xen: link against xentoolcore"):
> On Thu, Apr 19, 2018 at 05:45:06PM +0100, Ian Jackson wrote:
> > xen_pc="xencontrol xenstore xenguest xenforeignmemory xengnttab"
> > - xen_pc="$xen_pc xenevtchn xendevicemodel"
> > + xen_pc="$xen_pc xenevtchn xendevicemodel xentoolcore"
>
> I think we want to check if "xentoolcore" pkg_config exist before trying
> to use it. Otherwith, that is not going to work with Xen older than
> 4.10.
Yes. Thanks for spotting this. My tests were all with builds from in
the Xen tree and I hadn't spotted that that is handled as a special
case.
> Instead, we could do this:
> if $pkg_config --exists xentoolcore; then
> xen_pc+=" xentoolcore"
> fi
I will test that.
Ian.
- [Qemu-devel] [PATCH v7 00/16] xen: xen-domid-restrict improvements, Ian Jackson, 2018/04/19
- [Qemu-devel] [PATCH 01/16] checkpatch: Add xendevicemodel_handle to the list of types, Ian Jackson, 2018/04/19
- [Qemu-devel] [PATCH 03/16] xen: link against xentoolcore, Ian Jackson, 2018/04/19
- [Qemu-devel] [PATCH 06/16] xen: destroy_hvm_domain: Move reason into a variable, Ian Jackson, 2018/04/19
- [Qemu-devel] [PATCH 08/16] xen: destroy_hvm_domain: Try xendevicemodel_shutdown, Ian Jackson, 2018/04/19
- [Qemu-devel] [PATCH 13/16] xen: Expect xenstore write to fail when restricted, Ian Jackson, 2018/04/19
- [Qemu-devel] [PATCH 05/16] xen: defer call to xen_restrict until just before os_setup_post, Ian Jackson, 2018/04/19
- [Qemu-devel] [PATCH 04/16] xen: restrict: use xentoolcore_restrict_all, Ian Jackson, 2018/04/19
- [Qemu-devel] [PATCH 07/16] xen: move xc_interface compatibility fallback further up the file, Ian Jackson, 2018/04/19
- [Qemu-devel] [PATCH 09/16] os-posix: cleanup: Replace fprintfs with error_report in change_process_uid, Ian Jackson, 2018/04/19