[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 09/16] os-posix: cleanup: Replace fprintfs with erro
From: |
Ian Jackson |
Subject: |
[Qemu-devel] [PATCH 09/16] os-posix: cleanup: Replace fprintfs with error_report in change_process_uid |
Date: |
Thu, 19 Apr 2018 17:45:12 +0100 |
I'm going to be editing this function and it makes sense to clean up
this style problem in advance.
Signed-off-by: Ian Jackson <address@hidden>
CC: Paolo Bonzini <address@hidden>
CC: Markus Armbruster <address@hidden>
CC: Daniel P. Berrange <address@hidden>
CC: Michael Tokarev <address@hidden>
---
os-posix.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/os-posix.c b/os-posix.c
index b9c2343..560db95 100644
--- a/os-posix.c
+++ b/os-posix.c
@@ -167,20 +167,20 @@ static void change_process_uid(void)
{
if (user_pwd) {
if (setgid(user_pwd->pw_gid) < 0) {
- fprintf(stderr, "Failed to setgid(%d)\n", user_pwd->pw_gid);
+ error_report("Failed to setgid(%d)", user_pwd->pw_gid);
exit(1);
}
if (initgroups(user_pwd->pw_name, user_pwd->pw_gid) < 0) {
- fprintf(stderr, "Failed to initgroups(\"%s\", %d)\n",
- user_pwd->pw_name, user_pwd->pw_gid);
+ error_report("Failed to initgroups(\"%s\", %d)",
+ user_pwd->pw_name, user_pwd->pw_gid);
exit(1);
}
if (setuid(user_pwd->pw_uid) < 0) {
- fprintf(stderr, "Failed to setuid(%d)\n", user_pwd->pw_uid);
+ error_report("Failed to setuid(%d)", user_pwd->pw_uid);
exit(1);
}
if (setuid(0) != -1) {
- fprintf(stderr, "Dropping privileges failed\n");
+ error_report("Dropping privileges failed");
exit(1);
}
}
--
2.1.4
- [Qemu-devel] [PATCH 01/16] checkpatch: Add xendevicemodel_handle to the list of types, (continued)
- [Qemu-devel] [PATCH 01/16] checkpatch: Add xendevicemodel_handle to the list of types, Ian Jackson, 2018/04/19
- [Qemu-devel] [PATCH 03/16] xen: link against xentoolcore, Ian Jackson, 2018/04/19
- [Qemu-devel] [PATCH 06/16] xen: destroy_hvm_domain: Move reason into a variable, Ian Jackson, 2018/04/19
- [Qemu-devel] [PATCH 08/16] xen: destroy_hvm_domain: Try xendevicemodel_shutdown, Ian Jackson, 2018/04/19
- [Qemu-devel] [PATCH 13/16] xen: Expect xenstore write to fail when restricted, Ian Jackson, 2018/04/19
- [Qemu-devel] [PATCH 05/16] xen: defer call to xen_restrict until just before os_setup_post, Ian Jackson, 2018/04/19
- [Qemu-devel] [PATCH 04/16] xen: restrict: use xentoolcore_restrict_all, Ian Jackson, 2018/04/19
- [Qemu-devel] [PATCH 07/16] xen: move xc_interface compatibility fallback further up the file, Ian Jackson, 2018/04/19
- [Qemu-devel] [PATCH 09/16] os-posix: cleanup: Replace fprintfs with error_report in change_process_uid,
Ian Jackson <=
- [Qemu-devel] [PATCH 14/16] os-posix: cleanup: Replace fprintf with error_report in remaining call sites, Ian Jackson, 2018/04/19
- [Qemu-devel] [PATCH 10/16] os-posix: Provide new -runas <uid>:<gid> facility, Ian Jackson, 2018/04/19
- [Qemu-devel] [PATCH 11/16] xen: Use newly added dmops for mapping VGA memory, Ian Jackson, 2018/04/19
- [Qemu-devel] [PATCH 02/16] AccelClass: Introduce accel_setup_post, Ian Jackson, 2018/04/19
- [Qemu-devel] [PATCH 12/16] xen: Remove now-obsolete xen_xc_domain_add_to_physmap, Ian Jackson, 2018/04/19
- [Qemu-devel] [PATCH 15/16] os-posix: cleanup: Replace perror with error_report, Ian Jackson, 2018/04/19