qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 16/17] target/riscv: convert to DisasContextB


From: Emilio G. Cota
Subject: Re: [Qemu-devel] [PATCH v2 16/17] target/riscv: convert to DisasContextBase
Date: Mon, 9 Apr 2018 12:01:29 -0400
User-agent: Mutt/1.5.24 (2015-08-30)

On Mon, Apr 09, 2018 at 16:22:53 +0200, Bastian Koppelmann wrote:
> On 04/06/2018 08:19 PM, Emilio G. Cota wrote:
> > Notes:
> > 
> > - Did not convert {num,max}_insns, since the corresponding code
> >   will go away in the next patch.
> > 
> > - ctx->pc becomes ctx->base.pc_next, and ctx->next_pc becomes ctx->pc_tmp.
> 
> Please call pc_tmp something meaningful, like pc_succ_insn, or pc_next_next.

For v3 I've renamed it to ctx->pc_succ_insn, as you suggested.

Thanks,

                E.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]