Re: [Qemu-devel] [PATCH v2 00/17] Translation loop conversion for sh4/sparc/mips/s390x/openrisc/riscv targets

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v2 00/17] Translation loop conversion for 
sh4/sparc/mips/s390x/openrisc/riscv targets

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
   d7fa7fb504..08e173f294  master     -> master
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
3bf0c1c6d4 target/riscv: convert to TranslatorOps
8c8cf713ea target/riscv: convert to DisasContextBase
cda65dc923 target/riscv: convert to DisasJumpType
b959e20396 target/openrisc: convert to TranslatorOps
8a1f5ad2cd target/openrisc: convert to DisasContextBase
f6ef3b753a target/s390x: convert to TranslatorOps
8dad6fc829 target/s390x: convert to DisasContextBase
afc9aac550 target/s390x: convert to DisasJumpType
f588ffbd0c target/mips: convert to TranslatorOps
b8797aa5c2 target/mips: use *ctx for DisasContext
bf4f835373 target/mips: convert to DisasContextBase
a422870894 target/mips: convert to DisasJumpType
fdc97e620f target/sparc: convert to TranslatorOps
880c214bd0 target/sparc: convert to DisasContextBase
feec87def1 target/sparc: convert to DisasJumpType
5d0217ee29 target/sh4: convert to TranslatorOps
c1fffdaba5 translator: merge max_insns into DisasContextBase

=== OUTPUT BEGIN ===
Checking PATCH 1/17: translator: merge max_insns into DisasContextBase...
Checking PATCH 2/17: target/sh4: convert to TranslatorOps...
Checking PATCH 3/17: target/sparc: convert to DisasJumpType...
Checking PATCH 4/17: target/sparc: convert to DisasContextBase...
Checking PATCH 5/17: target/sparc: convert to TranslatorOps...
Checking PATCH 6/17: target/mips: convert to DisasJumpType...
Checking PATCH 7/17: target/mips: convert to DisasContextBase...
Checking PATCH 8/17: target/mips: use *ctx for DisasContext...
ERROR: space prohibited after that '&' (ctx:WxW)
#81: FILE: target/mips/translate.c:20220:
+    ctx->kscrexist = (env->CP0_Config4 >> CP0C4_KScrExist) & 0xff;
                                                            ^

total: 1 errors, 0 warnings, 254 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 9/17: target/mips: convert to TranslatorOps...
Checking PATCH 10/17: target/s390x: convert to DisasJumpType...
ERROR: braces {} are necessary for all arms of this statement
#3464: FILE: target/s390x/translate.c:6225:
+    } while (status == DISAS_NEXT);
[...]

total: 1 errors, 0 warnings, 3340 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 11/17: target/s390x: convert to DisasContextBase...
Checking PATCH 12/17: target/s390x: convert to TranslatorOps...
Checking PATCH 13/17: target/openrisc: convert to DisasContextBase...
ERROR: braces {} are necessary for all arms of this statement
#223: FILE: target/openrisc/translate.c:1605:
+    } while (!dc->base.is_jmp
[...]

total: 1 errors, 0 warnings, 246 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 14/17: target/openrisc: convert to TranslatorOps...
Checking PATCH 15/17: target/riscv: convert to DisasJumpType...
Checking PATCH 16/17: target/riscv: convert to DisasContextBase...
Checking PATCH 17/17: target/riscv: convert to TranslatorOps...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden