[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 01/12] checkpatch: Add xendevicemodel_handle to
From: |
Ian Jackson |
Subject: |
Re: [Qemu-devel] [PATCH 01/12] checkpatch: Add xendevicemodel_handle to the list of types |
Date: |
Mon, 26 Mar 2018 14:58:42 +0100 |
Paolo Bonzini writes ("Re: [PATCH 01/12] checkpatch: Add xendevicemodel_handle
to the list of types"):
> On 08/03/2018 20:02, Ian Jackson wrote:
> > This avoids checkpatch misparsing (as statements) long function
> > definitions or declarations, which sometimes start with constructs
> > like this:
> >
> > static inline int xendevicemodel_relocate_memory(
> > xendevicemodel_handle *dmod, domid_t domid, ...
...
>
> Or just rename it so that it is CamelCase. Then checkpatch will be happy.
I can do that if you want, although it seems a bit like pointless
churn. If I do that it ought to be renamed as well as re-spelled
because xendevicemodel_handle is actually a struct, not a "handle"
(ie, not a scalar).[1] So
s/xendevicemodel_handle/XendevicemodelInterface/
I guess ?
[1] If it were a scalar CODING_STYLE says it should be in lowercase
with _t. This is a violation of the C standard, which reserves names
ending _t for the implementation...
Ian.
- Re: [Qemu-devel] [PATCH 10/12] xen: Use newly added dmops for mapping VGA memory, (continued)
- [Qemu-devel] [PATCH 04/12] xen: defer call to xen_restrict until just before os_setup_post, Ian Jackson, 2018/03/08
- [Qemu-devel] [PATCH 07/12] xen: destroy_hvm_domain: Try xendevicemodel_shutdown, Ian Jackson, 2018/03/08
- [Qemu-devel] [PATCH 09/12] configure: do_compiler: Dump some extra info under bash, Ian Jackson, 2018/03/08
- [Qemu-devel] [PATCH 02/12] xen: link against xentoolcore, Ian Jackson, 2018/03/08
- [Qemu-devel] [PATCH 05/12] xen: destroy_hvm_domain: Move reason into a variable, Ian Jackson, 2018/03/08
- [Qemu-devel] [PATCH 03/12] xen: restrict: use xentoolcore_restrict_all, Ian Jackson, 2018/03/08
- [Qemu-devel] [PATCH 06/12] xen: move xc_interface compatibility fallback further up the file, Ian Jackson, 2018/03/08
- [Qemu-devel] [PATCH 01/12] checkpatch: Add xendevicemodel_handle to the list of types, Ian Jackson, 2018/03/08
- [Qemu-devel] [PATCH 08/12] os-posix: Provide new -runas <uid>:<gid> facility, Ian Jackson, 2018/03/08
- [Qemu-devel] [PATCH 12/12] scripts/get_maintainer.pl: Print proper error message for missing $file, Ian Jackson, 2018/03/08
- Re: [Qemu-devel] [PATCH v6.1 00/11] xen: xen-domid-restrict improvements, Ian Jackson, 2018/03/09