[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 01/12] checkpatch: Add xendevicemodel_handle to
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 01/12] checkpatch: Add xendevicemodel_handle to the list of types |
Date: |
Tue, 13 Mar 2018 16:11:00 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
On 08/03/2018 20:02, Ian Jackson wrote:
> This avoids checkpatch misparsing (as statements) long function
> definitions or declarations, which sometimes start with constructs
> like this:
>
> static inline int xendevicemodel_relocate_memory(
> xendevicemodel_handle *dmod, domid_t domid, ...
>
> CC: Eric Blake <address@hidden>
> CC: Paolo Bonzini <address@hidden>
> CC: Daniel P. Berrange <address@hidden>
> Signed-off-by: Ian Jackson <address@hidden>
> ---
> v6.1: New patch
> ---
> scripts/checkpatch.pl | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index d1fe79b..3e488f7 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -266,6 +266,7 @@ our @typeList = (
> qr{target_(?:u)?long},
> qr{hwaddr},
> qr{xml${Ident}},
> + qr{xendevicemodel_handle},
> );
>
> # This can be modified by sub possible. Since it can be empty, be careful
> --
Or just rename it so that it is CamelCase. Then checkpatch will be happy.
Paolo
- Re: [Qemu-devel] [PATCH 10/12] xen: Use newly added dmops for mapping VGA memory, (continued)
[Qemu-devel] [PATCH 04/12] xen: defer call to xen_restrict until just before os_setup_post, Ian Jackson, 2018/03/08
[Qemu-devel] [PATCH 07/12] xen: destroy_hvm_domain: Try xendevicemodel_shutdown, Ian Jackson, 2018/03/08
[Qemu-devel] [PATCH 09/12] configure: do_compiler: Dump some extra info under bash, Ian Jackson, 2018/03/08
[Qemu-devel] [PATCH 02/12] xen: link against xentoolcore, Ian Jackson, 2018/03/08
[Qemu-devel] [PATCH 05/12] xen: destroy_hvm_domain: Move reason into a variable, Ian Jackson, 2018/03/08
[Qemu-devel] [PATCH 03/12] xen: restrict: use xentoolcore_restrict_all, Ian Jackson, 2018/03/08
[Qemu-devel] [PATCH 06/12] xen: move xc_interface compatibility fallback further up the file, Ian Jackson, 2018/03/08
[Qemu-devel] [PATCH 01/12] checkpatch: Add xendevicemodel_handle to the list of types, Ian Jackson, 2018/03/08
- Re: [Qemu-devel] [PATCH 01/12] checkpatch: Add xendevicemodel_handle to the list of types,
Paolo Bonzini <=
[Qemu-devel] [PATCH 08/12] os-posix: Provide new -runas <uid>:<gid> facility, Ian Jackson, 2018/03/08
[Qemu-devel] [PATCH 12/12] scripts/get_maintainer.pl: Print proper error message for missing $file, Ian Jackson, 2018/03/08
Re: [Qemu-devel] [PATCH v6.1 00/11] xen: xen-domid-restrict improvements, Ian Jackson, 2018/03/09