[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.12 0/4] Turn OOB off for 2.12-rc1, revert
From: |
Christian Borntraeger |
Subject: |
Re: [Qemu-devel] [PATCH for-2.12 0/4] Turn OOB off for 2.12-rc1, revert OOB tests |
Date: |
Fri, 23 Mar 2018 19:30:42 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
On 03/23/2018 06:17 PM, Eric Blake wrote:
> On 03/23/2018 10:53 AM, Eric Blake wrote:
>
>> Actually, we should revert things in reverse order of the original commits,
>> so that we aren't introducing yet more temporary breakage.
>>
>> Since you reverted:
>>
>> $ git describe 3fd2457 d003f7a 91ad450 0213031 --match=v\*
>> v2.11.0-2595-g3fd2457d18e
>> v2.11.0-2598-gd003f7a8f9c
>> v2.11.0-2597-g91ad45061af
>> v2.11.0-2585-g02130314d8c
>>
>> where the higher the middle number represents the further distance from 2.11
>> (aka newer patch), this series should be applied in the order:
>>
>> 2/4 (revert the newest patch first)
>> 3/4
>> 1/4
>> 4/4
>
> Even that didn't work - 'make check' fails with either 1/4 or 4/4 applied in
> isolation, so I'm squashing them into a single patch.
Yes, "qmp: introduce QMPCapability" added an assert, that was fixed by a later
on patch. So
the original series was not bisectable. Anyway with Peters 4 patches all
applied things are fine
for me.
- Re: [Qemu-devel] [PATCH for-2.12 1/4] Revert "monitor: enable IO thread for (qmp & !mux) typed", (continued)
- [Qemu-devel] [PATCH for-2.12 2/4] Revert "tests: qmp-test: add oob test", Peter Xu, 2018/03/23
- [Qemu-devel] [PATCH for-2.12 3/4] Revert "tests: qmp-test: verify command batching", Peter Xu, 2018/03/23
- [Qemu-devel] [PATCH for-2.12 4/4] tests: partly revert "qmp: introduce QMPCapability", Peter Xu, 2018/03/23
- Re: [Qemu-devel] [PATCH for-2.12 0/4] Turn OOB off for 2.12-rc1, revert OOB tests, Peter Xu, 2018/03/23
- Re: [Qemu-devel] [PATCH for-2.12 0/4] Turn OOB off for 2.12-rc1, revert OOB tests, Eric Blake, 2018/03/23
- Re: [Qemu-devel] [PATCH for-2.12 0/4] Turn OOB off for 2.12-rc1, revert OOB tests, Eric Blake, 2018/03/23
- Re: [Qemu-devel] [PATCH for-2.12 0/4] Turn OOB off for 2.12-rc1, revert OOB tests, Eric Blake, 2018/03/23
- Re: [Qemu-devel] [PATCH for-2.12 0/4] Turn OOB off for 2.12-rc1, revert OOB tests,
Christian Borntraeger <=
- Re: [Qemu-devel] [PATCH for-2.12 0/4] Turn OOB off for 2.12-rc1, revert OOB tests, Eric Blake, 2018/03/23
- Re: [Qemu-devel] [PATCH for-2.12 0/4] Turn OOB off for 2.12-rc1, revert OOB tests, Peter Xu, 2018/03/23