[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH for-2.12 3/4] Revert "tests: qmp-test: verify comman
From: |
Peter Xu |
Subject: |
[Qemu-devel] [PATCH for-2.12 3/4] Revert "tests: qmp-test: verify command batching" |
Date: |
Fri, 23 Mar 2018 22:08:20 +0800 |
This reverts commit 91ad45061af0fe44ac5dadb5bedaf4d7a08077c8.
Signed-off-by: Peter Xu <address@hidden>
---
tests/qmp-test.c | 22 ----------------------
1 file changed, 22 deletions(-)
diff --git a/tests/qmp-test.c b/tests/qmp-test.c
index 2e4b599a4c..d1fa1cb217 100644
--- a/tests/qmp-test.c
+++ b/tests/qmp-test.c
@@ -82,7 +82,6 @@ static void test_qmp_protocol(void)
QTestState *qts;
const QListEntry *entry;
QString *qstr;
- int i;
qts = qtest_init_without_qmp_handshake(common_args);
@@ -140,27 +139,6 @@ static void test_qmp_protocol(void)
g_assert_cmpint(qdict_get_int(resp, "id"), ==, 2);
QDECREF(resp);
- /*
- * Test command batching. In current test OOB is not enabled, we
- * should be able to run as many commands in batch as we like.
- * Using 16 (>8, which is OOB queue length) to make sure OOB won't
- * break existing clients. Note: this test does not control the
- * scheduling of QEMU's QMP command processing threads so it may
- * not really trigger batching inside QEMU. This is just a
- * best-effort test.
- */
- for (i = 0; i < 16; i++) {
- qtest_async_qmp(qts, "{ 'execute': 'query-version' }");
- }
- /* Verify the replies to make sure no command is dropped. */
- for (i = 0; i < 16; i++) {
- resp = qtest_qmp_receive(qts);
- /* It should never be dropped. Each of them should be a reply. */
- g_assert(qdict_haskey(resp, "return"));
- g_assert(!qdict_haskey(resp, "event"));
- QDECREF(resp);
- }
-
qtest_quit(qts);
}
--
2.14.3
- [Qemu-devel] [PATCH for-2.12 0/4] Turn OOB off for 2.12-rc1, revert OOB tests, Peter Xu, 2018/03/23
- [Qemu-devel] [PATCH for-2.12 1/4] Revert "monitor: enable IO thread for (qmp & !mux) typed", Peter Xu, 2018/03/23
- [Qemu-devel] [PATCH for-2.12 2/4] Revert "tests: qmp-test: add oob test", Peter Xu, 2018/03/23
- [Qemu-devel] [PATCH for-2.12 3/4] Revert "tests: qmp-test: verify command batching",
Peter Xu <=
- [Qemu-devel] [PATCH for-2.12 4/4] tests: partly revert "qmp: introduce QMPCapability", Peter Xu, 2018/03/23
- Re: [Qemu-devel] [PATCH for-2.12 0/4] Turn OOB off for 2.12-rc1, revert OOB tests, Peter Xu, 2018/03/23
- Re: [Qemu-devel] [PATCH for-2.12 0/4] Turn OOB off for 2.12-rc1, revert OOB tests, Eric Blake, 2018/03/23
- Re: [Qemu-devel] [PATCH for-2.12 0/4] Turn OOB off for 2.12-rc1, revert OOB tests, Eric Blake, 2018/03/23
- Re: [Qemu-devel] [PATCH for-2.12 0/4] Turn OOB off for 2.12-rc1, revert OOB tests, Eric Blake, 2018/03/23
- Re: [Qemu-devel] [PATCH for-2.12 0/4] Turn OOB off for 2.12-rc1, revert OOB tests, Christian Borntraeger, 2018/03/23
- Re: [Qemu-devel] [PATCH for-2.12 0/4] Turn OOB off for 2.12-rc1, revert OOB tests, Eric Blake, 2018/03/23
- Re: [Qemu-devel] [PATCH for-2.12 0/4] Turn OOB off for 2.12-rc1, revert OOB tests, Peter Xu, 2018/03/23