[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 03/11] xen: defer call to xen_restrict until jus
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH 03/11] xen: defer call to xen_restrict until just before os_setup_post |
Date: |
Fri, 9 Mar 2018 09:58:33 -0300 |
User-agent: |
Mutt/1.9.2 (2017-12-15) |
On Fri, Mar 09, 2018 at 12:07:21PM +0000, Ian Jackson wrote:
> Ian Jackson writes ("Re: [PATCH 03/11] xen: defer call to xen_restrict until
> just before os_setup_post"):
> > Eduardo Habkost writes ("Re: [PATCH 03/11] xen: defer call to xen_restrict
> > until just before os_setup_post"):
> > > I don't think we should have accelerator-specific code in main(),
> > > if we already have accelerator classes that can abstract that
> > > out. I suggest adding a AccelClass;:setup_post() method that can
> > > be called here.
> >
> > I think I can do that.
>
> How about this ?
>
> From 61f11221afaa29e10021599420238e03836ba413 Mon Sep 17 00:00:00 2001
> From: Ian Jackson <address@hidden>
> Date: Fri, 9 Mar 2018 12:02:50 +0000
> Subject: [PATCH v6.2 12/11] AccelClass: Introduce accel_setup_post
>
> This is called just before os_setup_post. Currently none of the
> accelerators provide this hook, but the Xen one is going to provide
> one in a moment.
>
> Signed-off-by: Ian Jackson <address@hidden>
Looks good to me.
Reviewed-by: Eduardo Habkost <address@hidden>
That said, I don't think this should block the inclusion of the
previous patch in 2.12, if the Xen maintainers were already going
to merge it.
--
Eduardo
- [Qemu-devel] [PATCH 07/11] os-posix: Provide new -runas <uid>:<gid> facility, (continued)
- [Qemu-devel] [PATCH 07/11] os-posix: Provide new -runas <uid>:<gid> facility, Ian Jackson, 2018/03/08
- [Qemu-devel] [PATCH 06/11] xen: destroy_hvm_domain: Try xendevicemodel_shutdown, Ian Jackson, 2018/03/08
- [Qemu-devel] [PATCH 11/11] scripts/get_maintainer.pl: Print proper error message for missing $file, Ian Jackson, 2018/03/08
- [Qemu-devel] [PATCH 02/11] xen: restrict: use xentoolcore_restrict_all, Ian Jackson, 2018/03/08
- [Qemu-devel] [PATCH 03/11] xen: defer call to xen_restrict until just before os_setup_post, Ian Jackson, 2018/03/08
- Re: [Qemu-devel] [PATCH 03/11] xen: defer call to xen_restrict until just before os_setup_post, Eduardo Habkost, 2018/03/09
Re: [Qemu-devel] [PATCH v6 00/11] xen: xen-domid-restrict improvements, no-reply, 2018/03/08
Re: [Qemu-devel] [PATCH v6 00/11] xen: xen-domid-restrict improvements, no-reply, 2018/03/08
Re: [Qemu-devel] [PATCH v6 00/11] xen: xen-domid-restrict improvements, no-reply, 2018/03/08
Re: [Qemu-devel] [PATCH v6 00/11] xen: xen-domid-restrict improvements, no-reply, 2018/03/08
Re: [Qemu-devel] [PATCH v6 00/11] xen: xen-domid-restrict improvements, Ian Jackson, 2018/03/08