qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 03/11] xen: defer call to xen_restrict until jus


From: Eduardo Habkost
Subject: Re: [Qemu-devel] [PATCH 03/11] xen: defer call to xen_restrict until just before os_setup_post
Date: Fri, 9 Mar 2018 09:55:57 -0300
User-agent: Mutt/1.9.2 (2017-12-15)

On Fri, Mar 09, 2018 at 11:33:35AM +0000, Ian Jackson wrote:
> Eduardo Habkost writes ("Re: [PATCH 03/11] xen: defer call to xen_restrict 
> until just before os_setup_post"):
> > On Thu, Mar 08, 2018 at 05:39:09PM +0000, Ian Jackson wrote:
> > [...]
> > > diff --git a/vl.c b/vl.c
> > > +    xen_setup_post();
> > 
> > I don't think we should have accelerator-specific code in main(),
> > if we already have accelerator classes that can abstract that
> > out.  I suggest adding a AccelClass;:setup_post() method that can
> > be called here.
> 
> I think I can do that.
> 
> Although, it is a bit disappointing to be given this feedback in v6 of
> this series.  Did the right people not get CC'd on v5 in October ?

That is entirely my fault, for not paying attention to the patch
back in october (I was CCed on it).  Sorry for that.

-- 
Eduardo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]