Re: [Qemu-devel] [PULL 00/12] Ui 20180227 patches

[Peter Maydell]

On 28 February 2018 at 06:26, Gerd Hoffmann <address@hidden> wrote:
>   Hi,
>
>> Hi. This failed to build on my OpenBSD test box:
>>
>>   CC      qga/guest-agent-command-state.o
>> In file included from /home/qemu/include/qemu/osdep.h:30:0,
>>                  from /home/qemu/qga/guest-agent-command-state.c:12:
>> ./config-host.h:29:0: warning: "CONFIG_SDL" redefined
>>  #define CONFIG_SDL m
>>  ^
>> ./config-host.h:17:0: note: this is the location of the previous definition
>>  #define CONFIG_SDL 1
>>  ^
>>
>> (warning repeated for pretty much every object file)
>>
>> and then linking of the final executables failed with
>>
>> ../audio/audio.o:(.data.rel.ro+0x0): undefined reference to 
>> `sdl_audio_driver'
>
> Oh, right, there is sdl audio, completely forgot about that ...
>
> (this probably triggers on openbsd because sdl audio is the default
> there).
>
> I think modularizing SDL isn't that easy then.
> Can you just drop the "sdl: build as ui module" patch?

I can't drop patches from signed pull requests -- you need
to respin it.

thanks
-- PMM