[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 00/12] Ui 20180227 patches
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PULL 00/12] Ui 20180227 patches |
Date: |
Wed, 28 Feb 2018 07:26:34 +0100 |
User-agent: |
NeoMutt/20180223 |
Hi,
> Hi. This failed to build on my OpenBSD test box:
>
> CC qga/guest-agent-command-state.o
> In file included from /home/qemu/include/qemu/osdep.h:30:0,
> from /home/qemu/qga/guest-agent-command-state.c:12:
> ./config-host.h:29:0: warning: "CONFIG_SDL" redefined
> #define CONFIG_SDL m
> ^
> ./config-host.h:17:0: note: this is the location of the previous definition
> #define CONFIG_SDL 1
> ^
>
> (warning repeated for pretty much every object file)
>
> and then linking of the final executables failed with
>
> ../audio/audio.o:(.data.rel.ro+0x0): undefined reference to `sdl_audio_driver'
Oh, right, there is sdl audio, completely forgot about that ...
(this probably triggers on openbsd because sdl audio is the default
there).
I think modularizing SDL isn't that easy then.
Can you just drop the "sdl: build as ui module" patch?
cheers,
Gerd
- [Qemu-devel] [PULL 02/12] sdl: switch over to new display registry, (continued)
- [Qemu-devel] [PULL 02/12] sdl: switch over to new display registry, Gerd Hoffmann, 2018/02/27
- [Qemu-devel] [PULL 10/12] sdl: build as ui module, Gerd Hoffmann, 2018/02/27
- [Qemu-devel] [PULL 11/12] gtk: build as ui module, Gerd Hoffmann, 2018/02/27
- [Qemu-devel] [PULL 06/12] console: add and use qemu_display_find_default, Gerd Hoffmann, 2018/02/27
- [Qemu-devel] [PULL 04/12] curses: switch over to new display registry, Gerd Hoffmann, 2018/02/27
- [Qemu-devel] [PULL 07/12] console: add ui module loading support, Gerd Hoffmann, 2018/02/27
- [Qemu-devel] [PULL 01/12] console: add qemu display registry, add gtk, Gerd Hoffmann, 2018/02/27
- [Qemu-devel] [PULL 12/12] curses: build as ui module, Gerd Hoffmann, 2018/02/27
- [Qemu-devel] [PULL 05/12] egl-headless: switch over to new display registry, Gerd Hoffmann, 2018/02/27
- Re: [Qemu-devel] [PULL 00/12] Ui 20180227 patches, Peter Maydell, 2018/02/27
- Re: [Qemu-devel] [PULL 00/12] Ui 20180227 patches,
Gerd Hoffmann <=