[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 21/29] qapi/common: Fix guardname() for funny
From: |
Michael Roth |
Subject: |
Re: [Qemu-devel] [PATCH v2 21/29] qapi/common: Fix guardname() for funny filenames |
Date: |
Mon, 19 Feb 2018 12:18:48 -0600 |
User-agent: |
alot/0.6 |
Quoting Markus Armbruster (2018-02-11 03:35:59)
> guardname() fails to return a valid C identifier for arguments
> containing anything but [A-Za-z0-9_.-']. Fix that. Don't bother
> protecting ticklish identifiers; header guards are all-caps, and no
> ticklish identifiers are.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> Reviewed-by: Marc-André Lureau <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Michael Roth <address@hidden>
> ---
> scripts/qapi/common.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/qapi/common.py b/scripts/qapi/common.py
> index de12f8469a..6e5152b173 100644
> --- a/scripts/qapi/common.py
> +++ b/scripts/qapi/common.py
> @@ -1867,7 +1867,7 @@ def mcgen(code, **kwds):
>
>
> def guardname(filename):
> - return c_name(filename, protect=False).upper()
> + return re.sub(r'[^A-Za-z0-9_]', '_', filename).upper()
>
>
> def guardstart(name):
> --
> 2.13.6
>
- [Qemu-devel] [PATCH v2 00/29] Modularize generated QAPI code, Markus Armbruster, 2018/02/11
- [Qemu-devel] [PATCH v2 12/29] qapi/common: Eliminate QAPISchema.exprs, Markus Armbruster, 2018/02/11
- [Qemu-devel] [PATCH v2 04/29] qapi: Rename variable holding the QAPISchemaGenFOOVisitor, Markus Armbruster, 2018/02/11
- [Qemu-devel] [PATCH v2 21/29] qapi/common: Fix guardname() for funny filenames, Markus Armbruster, 2018/02/11
- Re: [Qemu-devel] [PATCH v2 21/29] qapi/common: Fix guardname() for funny filenames,
Michael Roth <=
- [Qemu-devel] [PATCH v2 25/29] docs/devel/writing-qmp-commands: Update for modular QAPI, Markus Armbruster, 2018/02/11
- [Qemu-devel] [PATCH v2 03/29] qapi: Generate up-to-date copyright notice, Markus Armbruster, 2018/02/11
- [Qemu-devel] [PATCH v2 01/29] Include qapi/qmp/qerror.h exactly where needed, Markus Armbruster, 2018/02/11