[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 12/29] qapi/common: Eliminate QAPISchema.expr
From: |
Michael Roth |
Subject: |
Re: [Qemu-devel] [PATCH v2 12/29] qapi/common: Eliminate QAPISchema.exprs |
Date: |
Sun, 18 Feb 2018 17:13:15 -0600 |
User-agent: |
alot/0.6 |
Quoting Markus Armbruster (2018-02-11 03:35:50)
> Signed-off-by: Markus Armbruster <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> Reviewed-by: Marc-André Lureau <address@hidden>
Reviewed-by: Michael Roth <address@hidden>
> ---
> scripts/qapi/common.py | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/scripts/qapi/common.py b/scripts/qapi/common.py
> index 3e92b38ade..d72c339ad5 100644
> --- a/scripts/qapi/common.py
> +++ b/scripts/qapi/common.py
> @@ -1461,13 +1461,13 @@ class QAPISchema(object):
> def __init__(self, fname):
> try:
> parser = QAPISchemaParser(open(fname, 'r'))
> - self.exprs = check_exprs(parser.exprs)
> + exprs = check_exprs(parser.exprs)
> self.docs = parser.docs
> self._entity_dict = {}
> self._predefining = True
> self._def_predefineds()
> self._predefining = False
> - self._def_exprs()
> + self._def_exprs(exprs)
> self.check()
> except QAPIError as err:
> print(err, file=sys.stderr)
> @@ -1652,8 +1652,8 @@ class QAPISchema(object):
> name, info, doc, 'arg', self._make_members(data, info))
> self._def_entity(QAPISchemaEvent(name, info, doc, data, boxed))
>
> - def _def_exprs(self):
> - for expr_elem in self.exprs:
> + def _def_exprs(self, exprs):
> + for expr_elem in exprs:
> expr = expr_elem['expr']
> info = expr_elem['info']
> doc = expr_elem.get('doc')
> --
> 2.13.6
>