[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/4] sdbus: add a QMP command to access a SDB
Re: [Qemu-devel] [PATCH v2 1/4] sdbus: add a QMP command to access a SDBus
Fri, 5 Jan 2018 10:10:35 -0600
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0
On 01/05/2018 10:06 AM, Philippe Mathieu-Daudé wrote:
> Hi Eric,
> On 01/05/2018 12:29 PM, Eric Blake wrote:
>> On 01/03/2018 03:49 PM, Philippe Mathieu-Daudé wrote:
>>> Use Base64 to serialize the binary blobs in JSON.
>>> So far at most 512 bytes will be transfered, which result
>>> in a 684 bytes payload.
>>> Since this command is intented for qtesting, it is acceptable.
>> Might be worth mentioning the actual command name,
>> x-debug-sdbus-command, in the commit message to make future git log
>> trawling easier.
> What about using 'x-qtest-sdbus-command'?
x-debug matches existing practice, x-qtest does not. I'm fine with the
name you had chosen, and was just asking that it be mentioned in the
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
Description: OpenPGP digital signature
Re: [Qemu-devel] [RFC PATCH v2 0/4] sdbus: testing sdcards, no-reply, 2018/01/03