[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 1/4] sdbus: add a QMP command to access a SDB

From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [PATCH v2 1/4] sdbus: add a QMP command to access a SDBus
Date: Fri, 5 Jan 2018 15:11:05 +0000
User-agent: Mutt/1.9.1 (2017-09-22)

On Wed, Jan 03, 2018 at 06:49:22PM -0300, Philippe Mathieu-Daudé wrote:
> Use Base64 to serialize the binary blobs in JSON.
> So far at most 512 bytes will be transfered, which result
> in a 684 bytes payload.
> Since this command is intented for qtesting, it is acceptable.

Not a requirement, but have you considered adding a qtest command

  > sdbus-command <qom-path> <args...>
  < OK <result...>

The (small) advantage is that it keeps test-only commands in the qtest
protocol and out of the QMP schema.

The downside of qtest is that qapi parsing is not available, so it
involves manual marshalling code.

Reviewed-by: Stefan Hajnoczi <address@hidden>

Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]