[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC v5 26/26] tests: qmp-test: add oob test
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [RFC v5 26/26] tests: qmp-test: add oob test |
|
Date: |
Thu, 14 Dec 2017 14:47:12 +0000 |
|
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On Tue, Dec 05, 2017 at 01:52:00PM +0800, Peter Xu wrote:
> + /* Try a fake capability, it should fail. */
> + resp = qmp("{ 'execute': 'qmp_capabilities', "
> + " 'arguments': { 'enable': [ 'cap-does-not-exist' ] } }");
> + g_assert(qdict_haskey(resp, "error"));
Missing QDECREF(resp) here and throughout the rest of the function.
Besides that:
Reviewed-by: Stefan Hajnoczi <address@hidden>
signature.asc
Description: PGP signature
- Re: [Qemu-devel] [RFC v5 23/26] qmp: add command "x-oob-test", (continued)
[Qemu-devel] [RFC v5 25/26] tests: qmp-test: verify command batching, Peter Xu, 2017/12/05
[Qemu-devel] [RFC v5 26/26] tests: qmp-test: add oob test, Peter Xu, 2017/12/05
- Re: [Qemu-devel] [RFC v5 26/26] tests: qmp-test: add oob test,
Stefan Hajnoczi <=
Re: [Qemu-devel] [RFC v5 00/26] QMP: out-of-band (OOB) execution support, Stefan Hajnoczi, 2017/12/14
Re: [Qemu-devel] [RFC v5 00/26] QMP: out-of-band (OOB) execution support, Fam Zheng, 2017/12/15