Re: [Qemu-devel] [RFC v5 25/26] tests: qmp-test: verify command batching

[Peter Xu]

On Thu, Dec 14, 2017 at 02:39:34PM +0000, Stefan Hajnoczi wrote:
> On Tue, Dec 05, 2017 at 01:51:59PM +0800, Peter Xu wrote:
> > OOB introduced DROP event for flow control.  This should not affect old
> > QMP clients.  Add a command batching check to make sure of it.
> > 
> > Signed-off-by: Peter Xu <address@hidden>
> > ---
> >  tests/qmp-test.c | 19 +++++++++++++++++++
> >  1 file changed, 19 insertions(+)
> > 
> > diff --git a/tests/qmp-test.c b/tests/qmp-test.c
> > index 292c5f135a..729ec59b0a 100644
> > --- a/tests/qmp-test.c
> > +++ b/tests/qmp-test.c
> > @@ -78,6 +78,7 @@ static void test_qmp_protocol(void)
> >      QList *capabilities;
> >      const QListEntry *entry;
> >      QString *qstr;
> > +    int i;
> >  
> >      global_qtest = qtest_init_without_qmp_handshake(common_args);
> >  
> > @@ -135,6 +136,24 @@ static void test_qmp_protocol(void)
> >      g_assert_cmpint(qdict_get_int(resp, "id"), ==, 2);
> >      QDECREF(resp);
> >  
> > +    /*
> > +     * Test command batching.  In current test OOB is not enabled, we
> > +     * should be able to run as many commands in batch as we like.
> > +     * Using 16 (>8, which is OOB queue length) to make sure OOB
> > +     * won't break existing clients.
> > +     */
> 
> It's possible that QEMU processes the command and responds before the
> test case submits the next one.  Please add:
> 
>   Note: this test does not control the scheduling of QEMU's QMP command
>   processing threads so it may not really trigger batching inside QEMU.
>   This is just a best-effort test.

True.

> 
> Reviewed-by: Stefan Hajnoczi <address@hidden>

Thanks,

-- 
Peter Xu