[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 5/6] hw/i386: deprecate the pc-0.10 and pc-0
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [RFC PATCH 5/6] hw/i386: deprecate the pc-0.10 and pc-0.11 machines |
Date: |
Wed, 8 Nov 2017 11:15:26 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
On 08.11.2017 10:16, Daniel P. Berrange wrote:
> On Tue, Nov 07, 2017 at 11:28:27PM -0300, Philippe Mathieu-Daudé wrote:
>> Both are deprecated since 2.9.0
>>
>> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
>> ---
>> hw/i386/pc_piix.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
>> index f79d5cb694..c462b702ff 100644
>> --- a/hw/i386/pc_piix.c
>> +++ b/hw/i386/pc_piix.c
>> @@ -941,6 +941,7 @@ static void pc_i440fx_0_11_machine_options(MachineClass
>> *m)
>> pc_i440fx_0_12_machine_options(m);
>> m->hw_version = "0.11";
>> SET_MACHINE_COMPAT(m, PC_COMPAT_0_11);
>> + m->deprecated_reason = "Too old";
>> }
>>
>> DEFINE_I440FX_MACHINE(v0_11, "pc-0.11", pc_compat_0_13,
>> @@ -976,6 +977,7 @@ static void pc_i440fx_0_10_machine_options(MachineClass
>> *m)
>> pc_i440fx_0_11_machine_options(m);
>> m->hw_version = "0.10";
>> SET_MACHINE_COMPAT(m, PC_COMPAT_0_10);
>> + m->deprecated_reason = "Too old";
>> }
>
> Any deprecation message should give users useful information about what
> they should do instead to avoid the problem.
+1
> More generally though, what would removing these two machines types allow
> us to actually achieve ? Seems quite arbitrary to pick 0.10 and 0.11 but
> leave the other 20+ machine types.
We've discussed this a couple of months ago on the mailing list: The
basic idea is that the oldest machine type that is still in use is 0.12
(as a base for the RHEL 6 machines), so we should avoid to get rid of
that code yet. But 0.10 and 0.11 very likely do not have any users
anymore, so it should be OK to deprecate them.
Thomas
[Qemu-devel] [RFC PATCH 6/6] hw/i386: deprecate the "isapc" machine, Philippe Mathieu-Daudé, 2017/11/07
Re: [Qemu-devel] [RFC PATCH 0/6] generic way to deprecate machines, Daniel P. Berrange, 2017/11/08