[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 2/6] hw/arm: deprecate the EP108 board
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [RFC PATCH 2/6] hw/arm: deprecate the EP108 board |
Date: |
Wed, 8 Nov 2017 09:17:45 +0000 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On Tue, Nov 07, 2017 at 11:28:24PM -0300, Philippe Mathieu-Daudé wrote:
> From: Alistair Francis <address@hidden>
>
> The EP108 was an early access development board that is no longer used.
> Add an info message to convert any users to the ZCU102 instead. On QEMU
> they are both identical.
>
> Signed-off-by: Alistair Francis <address@hidden>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hw/arm/xlnx-zcu102.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/hw/arm/xlnx-zcu102.c b/hw/arm/xlnx-zcu102.c
> index e2d15a1c9d..d42b6e3d3a 100644
> --- a/hw/arm/xlnx-zcu102.c
> +++ b/hw/arm/xlnx-zcu102.c
> @@ -164,6 +164,8 @@ static void xlnx_ep108_init(MachineState *machine)
> {
> XlnxZCU102 *s = EP108_MACHINE(machine);
>
> + info_report("Please use the ZCU102 machine instead of this machine.");
Why do we need this, in addition to the generic deprecation message that
says basically the same thing ?
> +
> xlnx_zynqmp_init(s, machine);
> }
>
> @@ -180,11 +182,13 @@ static void xlnx_ep108_machine_class_init(ObjectClass
> *oc, void *data)
> {
> MachineClass *mc = MACHINE_CLASS(oc);
>
> - mc->desc = "Xilinx ZynqMP EP108 board (Deprecated, please use
> xlnx-zcu102)";
> + mc->desc = "Xilinx ZynqMP EP108 board";
> mc->init = xlnx_ep108_init;
> mc->block_default_type = IF_IDE;
> mc->units_per_default_bus = 1;
> mc->ignore_memory_transaction_failures = true;
> + mc->deprecated_reason =
> + "The ZCU102 machine has the same features supported";
> }
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [Qemu-devel] [RFC PATCH 0/6] generic way to deprecate machines, Philippe Mathieu-Daudé, 2017/11/07
- [Qemu-devel] [RFC PATCH 1/6] machine: add a deprecated_reason property, Philippe Mathieu-Daudé, 2017/11/07
- [Qemu-devel] [RFC PATCH 2/6] hw/arm: deprecate the EP108 board, Philippe Mathieu-Daudé, 2017/11/07
- Re: [Qemu-devel] [RFC PATCH 2/6] hw/arm: deprecate the EP108 board,
Daniel P. Berrange <=
- [Qemu-devel] [RFC PATCH 3/6] hw/arm: deprecate the Gumstix boards, Philippe Mathieu-Daudé, 2017/11/07
- [Qemu-devel] [RFC PATCH 4/6] hw/ppc: deprecate the PReP machine, Philippe Mathieu-Daudé, 2017/11/07
- [Qemu-devel] [RFC PATCH 5/6] hw/i386: deprecate the pc-0.10 and pc-0.11 machines, Philippe Mathieu-Daudé, 2017/11/07
- Re: [Qemu-devel] [RFC PATCH 5/6] hw/i386: deprecate the pc-0.10 and pc-0.11 machines, Daniel P. Berrange, 2017/11/08
- Re: [Qemu-devel] [RFC PATCH 5/6] hw/i386: deprecate the pc-0.10 and pc-0.11 machines, Thomas Huth, 2017/11/08