On Wed, Sep 20, 2017 at 09:56:07AM -0700, Brandon Carpenter wrote:
How are things looking, Daniel. I believe every comment from the
previous
version of the series was addressed.
I also wanted to mention that I put together a Python script, which
acts as
a proxy between noVNC and qemu, and can inject various frame types,
fragment
frames, and shutdown the socket in various ways to help exercise the
different code paths. I would be happy to post it here to help test
the
changes.
Sorry for the delay - I've reviewed this now and it looks good. I've
made a
few whitespace changes in places, but I've queued it for my next pull
request
now.
Regards,
Daniel
--
|: https://berrange.com -o-
https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-
https://fstop138.berrange.com :|
|: https://entangle-photo.org -o-
https://www.instagram.com/dberrange :|