[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 0/7] Update websocket code to more fully supp
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PATCH v3 0/7] Update websocket code to more fully support the RFC |
Date: |
Thu, 21 Sep 2017 10:55:28 +0100 |
User-agent: |
Mutt/1.8.3 (2017-05-23) |
On Wed, Sep 20, 2017 at 09:56:07AM -0700, Brandon Carpenter wrote:
> How are things looking, Daniel. I believe every comment from the previous
> version of the series was addressed.
>
> I also wanted to mention that I put together a Python script, which acts as
> a proxy between noVNC and qemu, and can inject various frame types, fragment
> frames, and shutdown the socket in various ways to help exercise the
> different code paths. I would be happy to post it here to help test the
> changes.
Sorry for the delay - I've reviewed this now and it looks good. I've made a
few whitespace changes in places, but I've queued it for my next pull request
now.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [Qemu-devel] [PATCH v3 0/7] Update websocket code to more fully support the RFC, Brandon Carpenter, 2017/09/12
- [Qemu-devel] [PATCH v3 3/7] io: Add support for fragmented websocket binary frames, Brandon Carpenter, 2017/09/12
- [Qemu-devel] [PATCH v3 2/7] io: Small updates in preparation for websocket changes, Brandon Carpenter, 2017/09/12
- [Qemu-devel] [PATCH v3 1/7] io: Always remove an old channel watch before adding a new one, Brandon Carpenter, 2017/09/12
- [Qemu-devel] [PATCH v3 4/7] io: Allow empty websocket payload, Brandon Carpenter, 2017/09/12
- [Qemu-devel] [PATCH v3 7/7] io: Attempt to send websocket close messages to client, Brandon Carpenter, 2017/09/12
- [Qemu-devel] [PATCH v3 6/7] io: Reply to ping frames, Brandon Carpenter, 2017/09/12
- [Qemu-devel] [PATCH v3 5/7] io: Ignore websocket PING and PONG frames, Brandon Carpenter, 2017/09/12
- Re: [Qemu-devel] [PATCH v3 0/7] Update websocket code to more fully support the RFC, Stefan Hajnoczi, 2017/09/18
- Re: [Qemu-devel] [PATCH v3 0/7] Update websocket code to more fully support the RFC, Brandon Carpenter, 2017/09/20
- Re: [Qemu-devel] [PATCH v3 0/7] Update websocket code to more fully support the RFC,
Daniel P. Berrange <=