[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 08/22] s390x: move sclp_service_call() to scl
From: |
David Hildenbrand |
Subject: |
Re: [Qemu-devel] [PATCH v5 08/22] s390x: move sclp_service_call() to sclp.h |
Date: |
Wed, 13 Sep 2017 17:23:33 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 13.09.2017 17:21, Cornelia Huck wrote:
> On Wed, 13 Sep 2017 16:29:23 +0200
> Thomas Huth <address@hidden> wrote:
>
>> On 13.09.2017 15:24, David Hildenbrand wrote:
>>> Implemented in sclp.c, so let's move it to the right include file.
>>> Fix up one include. Do a forward declaration of struct CPUS390XState to
>>> fix the two sclp consoles complaining.
>>
>> Is that sentence about the forward declaration still valid? I did not
>> see that anymore here...
>
> Indeed. I can fix this up to:
>
> "Implemented in sclp.c, so let's move it to the right include file.
> Also adjust some includes."
>
> ?
You know how to use just the right words ;) Thanks!
--
Thanks,
David
- Re: [Qemu-devel] [PATCH v5 03/22] s390x: get rid of s390-virtio.c, (continued)
- [Qemu-devel] [PATCH v5 04/22] s390x: rename s390-virtio.h to s390-virtio-hcall.h, David Hildenbrand, 2017/09/13
- [Qemu-devel] [PATCH v5 05/22] s390x: move s390_virtio_hypercall() to s390-virtio-hcall.h, David Hildenbrand, 2017/09/13
- [Qemu-devel] [PATCH v5 06/22] s390x: move subsystem_reset() to s390-virtio-ccw.h, David Hildenbrand, 2017/09/13
- [Qemu-devel] [PATCH v5 09/22] target/s390x: use trigger_pgm_exception() in s390_cpu_handle_mmu_fault(), David Hildenbrand, 2017/09/13
- [Qemu-devel] [PATCH v5 08/22] s390x: move sclp_service_call() to sclp.h, David Hildenbrand, 2017/09/13
- [Qemu-devel] [PATCH v5 07/22] target/s390x: move some s390x typedefs to cpu-qom.h, David Hildenbrand, 2017/09/13
[Qemu-devel] [PATCH v5 10/22] target/s390x: use program_interrupt() in per_check_exception(), David Hildenbrand, 2017/09/13
[Qemu-devel] [PATCH v5 11/22] s390x: allow only 1 CPU with TCG, David Hildenbrand, 2017/09/13