[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 17/21] s390x: CPU hot unplug via device_del canno
From: |
David Hildenbrand |
Subject: |
[Qemu-devel] [PATCH v3 17/21] s390x: CPU hot unplug via device_del cannot work for now |
Date: |
Thu, 7 Sep 2017 22:13:31 +0200 |
device_del on a CPU will currently do nothing. Let's emmit an error
telling that this is will currently not work (there is no architecture
support on s390x). Error message copied from ppc.
(qemu) device_del cpu1
device_del cpu1
CPU hot unplug not supported on this machine
Reviewed-by: Matthew Rosato <address@hidden>
Signed-off-by: David Hildenbrand <address@hidden>
---
hw/s390x/s390-virtio-ccw.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c
index 2086eb6ca6..120f82e339 100644
--- a/hw/s390x/s390-virtio-ccw.c
+++ b/hw/s390x/s390-virtio-ccw.c
@@ -341,6 +341,15 @@ static void s390_machine_device_plug(HotplugHandler
*hotplug_dev,
}
}
+static void s390_machine_device_unplug_request(HotplugHandler *hotplug_dev,
+ DeviceState *dev, Error **errp)
+{
+ if (object_dynamic_cast(OBJECT(dev), TYPE_CPU)) {
+ error_setg(errp, "CPU hot unplug not supported on this machine");
+ return;
+ }
+}
+
static HotplugHandler *s390_get_hotplug_handler(MachineState *machine,
DeviceState *dev)
{
@@ -390,6 +399,7 @@ static void ccw_machine_class_init(ObjectClass *oc, void
*data)
mc->max_cpus = 248;
mc->get_hotplug_handler = s390_get_hotplug_handler;
hc->plug = s390_machine_device_plug;
+ hc->unplug_request = s390_machine_device_unplug_request;
nc->nmi_monitor_handler = s390_nmi;
}
--
2.13.5
- [Qemu-devel] [PATCH v3 07/21] s390x: move subsystem_reset() to s390-virtio-ccw.h, (continued)
- [Qemu-devel] [PATCH v3 07/21] s390x: move subsystem_reset() to s390-virtio-ccw.h, David Hildenbrand, 2017/09/07
- [Qemu-devel] [PATCH v3 08/21] s390x: move sclp_service_call() to sclp.h, David Hildenbrand, 2017/09/07
- [Qemu-devel] [PATCH v3 09/21] target/s390x: use trigger_pgm_exception() in s390_cpu_handle_mmu_fault(), David Hildenbrand, 2017/09/07
- [Qemu-devel] [PATCH v3 10/21] target/s390x: use program_interrupt() in per_check_exception(), David Hildenbrand, 2017/09/07
- [Qemu-devel] [PATCH v3 11/21] s390x: allow only 1 CPU with TCG, David Hildenbrand, 2017/09/07
- [Qemu-devel] [PATCH v3 12/21] target/s390x: set cpu->id for linux user when realizing, David Hildenbrand, 2017/09/07
- [Qemu-devel] [PATCH v3 13/21] target/s390x: use "core-id" for cpu number/address/id handling, David Hildenbrand, 2017/09/07
- [Qemu-devel] [PATCH v3 14/21] target/s390x: rename next_cpu_id to next_core_id, David Hildenbrand, 2017/09/07
- [Qemu-devel] [PATCH v3 15/21] s390x: print CPU definitions in sorted order, David Hildenbrand, 2017/09/07
- [Qemu-devel] [PATCH v3 16/21] s390x: allow cpu hotplug via device_add, David Hildenbrand, 2017/09/07
- [Qemu-devel] [PATCH v3 17/21] s390x: CPU hot unplug via device_del cannot work for now,
David Hildenbrand <=
- [Qemu-devel] [PATCH v3 18/21] s390x: implement query-hotpluggable-cpus, David Hildenbrand, 2017/09/07
- [Qemu-devel] [PATCH v3 19/21] s390x: get rid of cpu_s390x_create(), David Hildenbrand, 2017/09/07
- [Qemu-devel] [PATCH v3 20/21] s390x: generate sclp cpu information from possible_cpus, David Hildenbrand, 2017/09/07
- [Qemu-devel] [PATCH v3 21/21] s390x: allow CPU hotplug in random core-id order, David Hildenbrand, 2017/09/07