[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 12/21] target/s390x: set cpu->id for linux user w
From: |
David Hildenbrand |
Subject: |
[Qemu-devel] [PATCH v3 12/21] target/s390x: set cpu->id for linux user when realizing |
Date: |
Thu, 7 Sep 2017 22:13:26 +0200 |
scc->next_cpu_id is updated when realizing. Setting it just before that
point looks cleaner.
Reviewed-by: Matthew Rosato <address@hidden>
Signed-off-by: David Hildenbrand <address@hidden>
---
target/s390x/cpu.c | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/target/s390x/cpu.c b/target/s390x/cpu.c
index 74b3e4fd0d..5f9315fb16 100644
--- a/target/s390x/cpu.c
+++ b/target/s390x/cpu.c
@@ -194,7 +194,11 @@ static void s390_cpu_realizefn(DeviceState *dev, Error
**errp)
", max allowed: %d", cpu->id, max_cpus - 1);
goto out;
}
+#else
+ /* implicitly set for linux-user only */
+ cpu->id = scc->next_cpu_id;
#endif
+
if (cpu_exists(cpu->id)) {
error_setg(&err, "Unable to add CPU: %" PRIi64
", it already exists", cpu->id);
@@ -306,13 +310,6 @@ static void s390_cpu_initfn(Object *obj)
inited = true;
s390x_translate_init();
}
-
-#if defined(CONFIG_USER_ONLY)
- {
- S390CPUClass *scc = S390_CPU_GET_CLASS(obj);
- cpu->id = scc->next_cpu_id;
- }
-#endif
}
static void s390_cpu_finalize(Object *obj)
--
2.13.5
- [Qemu-devel] [PATCH v3 02/21] cpu: drop old comments describing members, (continued)
- [Qemu-devel] [PATCH v3 02/21] cpu: drop old comments describing members, David Hildenbrand, 2017/09/07
- [Qemu-devel] [PATCH v3 04/21] s390x: rename s390-virtio.h to s390-virtio-hcall.h, David Hildenbrand, 2017/09/07
- [Qemu-devel] [PATCH v3 03/21] s390x: get rid of s390-virtio.c, David Hildenbrand, 2017/09/07
- [Qemu-devel] [PATCH v3 05/21] target/s390x: move typedef of S390CPU to its definition, David Hildenbrand, 2017/09/07
- [Qemu-devel] [PATCH v3 06/21] s390x: move s390_virtio_hypercall() to s390-virtio-hcall.h, David Hildenbrand, 2017/09/07
- [Qemu-devel] [PATCH v3 07/21] s390x: move subsystem_reset() to s390-virtio-ccw.h, David Hildenbrand, 2017/09/07
- [Qemu-devel] [PATCH v3 08/21] s390x: move sclp_service_call() to sclp.h, David Hildenbrand, 2017/09/07
- [Qemu-devel] [PATCH v3 09/21] target/s390x: use trigger_pgm_exception() in s390_cpu_handle_mmu_fault(), David Hildenbrand, 2017/09/07
- [Qemu-devel] [PATCH v3 10/21] target/s390x: use program_interrupt() in per_check_exception(), David Hildenbrand, 2017/09/07
- [Qemu-devel] [PATCH v3 11/21] s390x: allow only 1 CPU with TCG, David Hildenbrand, 2017/09/07
- [Qemu-devel] [PATCH v3 12/21] target/s390x: set cpu->id for linux user when realizing,
David Hildenbrand <=
- [Qemu-devel] [PATCH v3 13/21] target/s390x: use "core-id" for cpu number/address/id handling, David Hildenbrand, 2017/09/07
- [Qemu-devel] [PATCH v3 14/21] target/s390x: rename next_cpu_id to next_core_id, David Hildenbrand, 2017/09/07
- [Qemu-devel] [PATCH v3 15/21] s390x: print CPU definitions in sorted order, David Hildenbrand, 2017/09/07
- [Qemu-devel] [PATCH v3 16/21] s390x: allow cpu hotplug via device_add, David Hildenbrand, 2017/09/07
- [Qemu-devel] [PATCH v3 17/21] s390x: CPU hot unplug via device_del cannot work for now, David Hildenbrand, 2017/09/07
- [Qemu-devel] [PATCH v3 18/21] s390x: implement query-hotpluggable-cpus, David Hildenbrand, 2017/09/07
- [Qemu-devel] [PATCH v3 19/21] s390x: get rid of cpu_s390x_create(), David Hildenbrand, 2017/09/07
- [Qemu-devel] [PATCH v3 20/21] s390x: generate sclp cpu information from possible_cpus, David Hildenbrand, 2017/09/07
- [Qemu-devel] [PATCH v3 21/21] s390x: allow CPU hotplug in random core-id order, David Hildenbrand, 2017/09/07